You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/03/30 14:30:25 UTC

[jira] [Commented] (IGNITE-2914) ODBC: QueriesTestSuite from odbc-test uses outdated version of MakeDate and MakeTimestamp.

    [ https://issues.apache.org/jira/browse/IGNITE-2914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15217887#comment-15217887 ] 

ASF GitHub Bot commented on IGNITE-2914:
----------------------------------------

GitHub user isapego opened a pull request:

    https://github.com/apache/ignite/pull/586

    IGNITE-2914: Removed MakeDate and MakeTimestamp.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/isapego/ignite ignite-2914

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/586.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #586
    
----
commit 1b9a1b6cda95cdd9b83884859b7f010de4b0304f
Author: isapego <is...@gridgain.com>
Date:   2016-03-15T14:39:24Z

    IGNITE-2823: Splitted common in two libs.

commit 6368c25720270817f12fee6f751178096d9a1010
Author: isapego <is...@gridgain.com>
Date:   2016-03-15T14:53:43Z

    IGNITE-2823: Moved utils lib files to "utils" include dir.

commit 5d01177e4e9b89c7b7d7d4dc3002ce69b2a61438
Author: isapego <is...@gridgain.com>
Date:   2016-03-15T15:04:16Z

    IGNITE-2823: Moved utils to its own namespace.

commit 73f9ab6af21a2b8aaac06b836bf7ca59da16182e
Author: Igor Sapego <is...@gridgain.com>
Date:   2016-03-15T15:37:16Z

    IGNITE-2823: Autotools build of utils implemented.

commit c41bad6f60d02c297c95d6698d98773a0c07b100
Author: Igor Sapego <is...@gridgain.com>
Date:   2016-03-15T16:23:08Z

    IGNITE-2823: Fixes for the Autotools build system.

commit 7ab9732f8d169f3e7bde8f12fc15aa76721d4c00
Author: isapego <is...@gridgain.com>
Date:   2016-03-15T16:56:19Z

    IGNITE-2823: minor refactoring.

commit b26cdc41a96f51780991e67e171c5000e931a33e
Author: isapego <is...@gridgain.com>
Date:   2016-03-17T15:45:53Z

    Merge branch 'ignite-1786' into ignite-2823

commit d41afdd528abdfe05c8a3782a0b4cd6d907ae83d
Author: isapego <is...@gridgain.com>
Date:   2016-03-23T12:25:52Z

    Merge branch 'ignite-1786' into ignite-2823

commit 7e2357d27f592564a5e8a312307348e66d98cbac
Author: isapego <is...@gridgain.com>
Date:   2016-03-23T12:43:04Z

    IGNITE-2823: Merge-related fixes.

commit c146fc4d5c136706044a1b19a2a5b16552d9550c
Author: isapego <is...@gridgain.com>
Date:   2016-03-23T13:54:51Z

    IGNITE-2823: Renamed: common => jni, utils => common.

commit c68d7907367a9c27218cbe7590cb8baddc44a26d
Author: Igor Sapego <is...@gridgain.com>
Date:   2016-03-23T14:30:08Z

    IGNITE-2823: Fixes for Linux.

commit 21f20335d7ba1cb9e48908053a342f188d33d7fb
Author: isapego <is...@gridgain.com>
Date:   2016-03-23T14:48:09Z

    IGNITE-2823: Renamed namspaces: common => jni, utils => common.

commit 7450a5bfc1aba6e91ac22ca66622e27928d6f117
Author: isapego <is...@gridgain.com>
Date:   2016-03-23T15:05:17Z

    IGNITE-2823: Fix for Debug version.

commit a1da841d566b2df1221d6e1d2a836704ca9f1ef3
Author: isapego <is...@gridgain.com>
Date:   2016-03-23T15:38:19Z

    IGNITE-2823: Fixes for .NET

commit 9d291715997984d72db112dd7cdea888b5df2209
Author: Igor Sapego <is...@gridgain.com>
Date:   2016-03-23T17:56:27Z

    Save

commit 24e16cd2d95e9c310deaf8d95360a3f96527067e
Author: Igor Sapego <is...@gridgain.com>
Date:   2016-03-28T16:11:33Z

    IGNITE-2823: Autotools build system reworked.

commit 34ef5166f6b63c6e14f3c4d4e6adbbec8fe317d9
Author: Igor Sapego <is...@gridgain.com>
Date:   2016-03-28T16:49:19Z

    IGNITE-2823: Added headers to DIST.

commit a377091a16bb5125a2a376ae24091bdeffae01a1
Author: Igor Sapego <is...@gridgain.com>
Date:   2016-03-28T17:06:41Z

    IGNITE-2823: Removed examples from the root cfg.

commit 0fd7b014d037bcf210253de6a83b5e70789cc47d
Author: Igor Sapego <is...@gridgain.com>
Date:   2016-03-29T14:01:41Z

    IGNITE-2823: Minor fixes. column_test.cpp added to odbc-tests.

commit e46afd89217e99dc6ed1dc7f5695c1883559aec6
Author: Igor Sapego <is...@gridgain.com>
Date:   2016-03-29T14:23:36Z

    IGNITE-2823: Added core/ignite.pc to AC_CONFIG_FILES.

commit ac15b2c1fd7b06c96e97bde2302440c2c1331d8f
Author: Igor Sapego <is...@gridgain.com>
Date:   2016-03-29T14:33:31Z

    IGNITE-2823: Added release version of configure.ac and Makefile.am.

commit 052bc51d722cbe8d88a20e7287b57ad09535ce32
Author: Igor Sapego <is...@gridgain.com>
Date:   2016-03-29T14:57:06Z

    IGNITE-2823: Examples build reworked

commit c77723d80f35928b8f38b54bff35a3f89b0713cd
Author: Igor Sapego <is...@gridgain.com>
Date:   2016-03-29T15:28:54Z

    IGNITE-2823: Fixed assembly.

commit 05f762a828b041a75d61296251f8b9eefba17564
Author: Igor Sapego <is...@gridgain.com>
Date:   2016-03-29T15:33:36Z

    Merge branch 'ignite-1786' into ignite-2823

commit 5ea069a4bf76016c42d76d86d05b344445ce6907
Author: Igor Sapego <is...@gridgain.com>
Date:   2016-03-29T15:39:04Z

    IGNITE-2823: Enable ODBC and Tests by default for non-release builds.

commit 3f1e5087f4241aac2bd1edfb3927d7f6960bb4e6
Author: Igor Sapego <is...@gridgain.com>
Date:   2016-03-29T16:36:45Z

    IGNITE-2823: Fixes for 'make [un]install' command.

commit 6cc2f75b0a0c85b05c4b0cfd5ca838d33c2cf14f
Author: isapego <is...@gridgain.com>
Date:   2016-03-29T16:55:23Z

    IGNITE-2823: Moved Date, Timestamp and Guid to libcommon.

commit d73940a523c562df3c7dbd2f1b47f5e701cabcc7
Author: Igor Sapego <is...@gridgain.com>
Date:   2016-03-29T17:23:15Z

    IGNITE-2823: Docs fixed.

commit 683b617a281485a6c22b31a887001486cad305a9
Author: isapego <is...@gridgain.com>
Date:   2016-03-29T17:36:22Z

    IGNITE-2823: Disabled building of the ODBC by default by VS.

commit 470ec9112c153a0e0919913514019a4f07dc00fc
Author: Igor Sapego <is...@gridgain.com>
Date:   2016-03-29T18:00:58Z

    IGNITE-2823: Excluded .ini from header-check.

----


> ODBC: QueriesTestSuite from odbc-test uses outdated version of MakeDate and MakeTimestamp.
> ------------------------------------------------------------------------------------------
>
>                 Key: IGNITE-2914
>                 URL: https://issues.apache.org/jira/browse/IGNITE-2914
>             Project: Ignite
>          Issue Type: Sub-task
>          Components: odbc
>    Affects Versions: 1.5.0.final
>            Reporter: Igor Sapego
>            Assignee: Igor Sapego
>             Fix For: 1.6
>
>
> Seems like there are outdated versions of MakeDate and MakeTimestamp declared in ODBC test_utils. They should be removed and calls to them should be replaced with following functions:
> {{BinaryUtils::MakeTimestampLocal}}, 
> {{BinaryUtils::MakeDateLocal}},
> {{BinaryUtils::MakeTimestampGmt}},
> {{BinaryUtils::MakeDateGmt}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)