[jira] [Comment Edited] (OOZIE-3314) Remove findbugs-filter.xml and convert its contents to annotations

["Andras Salamon (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OOZIE-3314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571621#comment-16571621 ] 

Andras Salamon edited comment on OOZIE-3314 at 8/9/18 7:49 AM:
---------------------------------------------------------------

[~andras.piros] Created a review board for the request: [https://reviews.apache.org/r/68255/]


was (Author: asalamon74):
[~andras.piros] Created a review board for the request: [https://reviews.apache.org/r/68255/|http://example.com/]

> Remove findbugs-filter.xml and convert its contents to annotations
> ------------------------------------------------------------------
>
>                 Key: OOZIE-3314
>                 URL: https://issues.apache.org/jira/browse/OOZIE-3314
>             Project: Oozie
>          Issue Type: Bug
>          Components: core
>            Reporter: Peter Bacsko
>            Assignee: Andras Salamon
>            Priority: Major
>             Fix For: 5.1.0
>
>         Attachments: OOZIE-3314-1.patch, OOZIE-3314-2.patch
>
>
> In oozie-core, we have a file called "findbugs-filter.xml" which tells findbugs that it shluld ignore certain problems in a couple of classes.
> However if we try to compile a sub-module or run findbugs directly (let's say in a sharelib project), the build will fail because it won't be able to open findbugs.xml. It's not straightforward how to define the path of the XML in a way that it makes this xml accessible regardless of what module you're compiling.
> It's better to just convert its contents to annotations - especially since we already use this method too.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)