You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/06/01 03:47:42 UTC

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1926: fix: route edit page suspend due to the form shouldupdate

liuxiran commented on a change in pull request #1926:
URL: https://github.com/apache/apisix-dashboard/pull/1926#discussion_r642762250



##########
File path: web/src/pages/Route/components/Step1/MetaView.tsx
##########
@@ -205,6 +205,7 @@ const MetaView: React.FC<RouteModule.Step1PassProps> = ({ disabled, form, isEdit
             >
               <Select
                 disabled={disabled}
+                data-cy='route-redirect'
                 onChange={(parmas) => {

Review comment:
       > can you also fix the typo to params in this PR?
   
   Thanks for your review, and just to make sure that I should change the typo of `route-direct` right? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org