You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2020/04/13 17:12:46 UTC
[GitHub] [knox] lokeshj1703 opened a new pull request #314: KNOX-2321.
/LogLevel with knox not working for Hdfs web ui endpoints.
lokeshj1703 opened a new pull request #314: KNOX-2321. /LogLevel with knox not working for Hdfs web ui endpoints.
URL: https://github.com/apache/knox/pull/314
## What changes were proposed in this pull request?
Add a rewrite rule for LogLevel in hdfs ui.
## How was this patch tested?
The patch was tested on a cluster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [knox] bharatviswa504 commented on issue #314: KNOX-2321 - HDFS UI
rewrite rules should handle LogLevel
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on issue #314: KNOX-2321 - HDFS UI rewrite rules should handle LogLevel
URL: https://github.com/apache/knox/pull/314#issuecomment-613003506
This link is added to DN and explorer page also, do we need some changes for Dn and explorer rewrite rules also to make it work?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [knox] moresandeep commented on issue #314: KNOX-2321 - HDFS UI
rewrite rules should handle LogLevel
Posted by GitBox <gi...@apache.org>.
moresandeep commented on issue #314: KNOX-2321 - HDFS UI rewrite rules should handle LogLevel
URL: https://github.com/apache/knox/pull/314#issuecomment-613168909
Ah right, I'll merge this and we will followup with new JIRA if needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [knox] moresandeep commented on issue #314: KNOX-2321 - HDFS UI
rewrite rules should handle LogLevel
Posted by GitBox <gi...@apache.org>.
moresandeep commented on issue #314: KNOX-2321 - HDFS UI rewrite rules should handle LogLevel
URL: https://github.com/apache/knox/pull/314#issuecomment-613146060
> Would the other UIs be addressed via global rewrite rules by any chance?
Global rewrite rule is a double edge sword, it might break other UIs unknowingly. I think some code duplication might be tolerable in this case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [knox] moresandeep commented on issue #314: KNOX-2321 - HDFS UI
rewrite rules should handle LogLevel
Posted by GitBox <gi...@apache.org>.
moresandeep commented on issue #314: KNOX-2321 - HDFS UI rewrite rules should handle LogLevel
URL: https://github.com/apache/knox/pull/314#issuecomment-613032168
> This link is added to DN and explorer page also, do we need some changes for Dn and explorer rewrite rules also to make it work?
We probably, should, @lokeshj1703 thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [knox] lmccay commented on issue #314: KNOX-2321 - HDFS UI rewrite
rules should handle LogLevel
Posted by GitBox <gi...@apache.org>.
lmccay commented on issue #314: KNOX-2321 - HDFS UI rewrite rules should handle LogLevel
URL: https://github.com/apache/knox/pull/314#issuecomment-613156374
Okay - I want to cut an RC in the next day or so - so let's get this resolved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [knox] lmccay commented on issue #314: KNOX-2321 - HDFS UI rewrite
rules should handle LogLevel
Posted by GitBox <gi...@apache.org>.
lmccay commented on issue #314: KNOX-2321 - HDFS UI rewrite rules should handle LogLevel
URL: https://github.com/apache/knox/pull/314#issuecomment-613132212
Would the other UIs be addressed via global rewrite rules by any chance?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [knox] moresandeep merged pull request #314: KNOX-2321 - HDFS UI
rewrite rules should handle LogLevel
Posted by GitBox <gi...@apache.org>.
moresandeep merged pull request #314: KNOX-2321 - HDFS UI rewrite rules should handle LogLevel
URL: https://github.com/apache/knox/pull/314
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [knox] lokeshj1703 commented on issue #314: KNOX-2321 - HDFS UI
rewrite rules should handle LogLevel
Posted by GitBox <gi...@apache.org>.
lokeshj1703 commented on issue #314: KNOX-2321 - HDFS UI rewrite rules should handle LogLevel
URL: https://github.com/apache/knox/pull/314#issuecomment-613227110
@bharatviswa504 @moresandeep I think it should be fine. The rewrite rules are added under section.
`<!-- outbound rewrite rules for links under utilities -->`
I think these rewrite rules apply for datanode as well as explorer html.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services