[kudu-CR] [rest] add oat++ framework to kudu

["Khazar Mammadli (Code Review)" <ge...@cloudera.org>]

Khazar Mammadli has posted comments on this change. ( http://gerrit.cloudera.org:8080/17554 )

Change subject: [rest] add oat++ framework to kudu
......................................................................


Patch Set 16:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/17554/16/cmake_modules/FindOatpp.cmake
File cmake_modules/FindOatpp.cmake:

http://gerrit.cloudera.org:8080/#/c/17554/16/cmake_modules/FindOatpp.cmake@24
PS16, Line 24: oatpp-1.2.5
> Is there a way to use version-agnostic path here?  Using version-specific p
It is possible but I have to change the CmakeLists.txt for the Oat++ and the Swagger and reupload them to the S3


http://gerrit.cloudera.org:8080/#/c/17554/16/cmake_modules/FindOatppSwagger.cmake
File cmake_modules/FindOatppSwagger.cmake:

http://gerrit.cloudera.org:8080/#/c/17554/16/cmake_modules/FindOatppSwagger.cmake@24
PS16, Line 24: oatpp-1.2.5
> ditto: is it possible to switch to a version-agnostic path here?
It is possible, but I have to change the CmakeLists.txt for the Oat++ Swagger and reupload it to the S3



-- 
To view, visit http://gerrit.cloudera.org:8080/17554
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7
Gerrit-Change-Number: 17554
Gerrit-PatchSet: 16
Gerrit-Owner: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Khazar Mammadli <ma...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 01 Jul 2021 15:24:32 +0000
Gerrit-HasComments: Yes