[GitHub] [netbeans] rossluk commented on a diff in pull request #5681: [PHP] Multiple default namespace navigator fix, FixImports for the whole file

["rossluk (via GitHub)" <gi...@apache.org>]

rossluk commented on code in PR #5681:
URL: https://github.com/apache/netbeans/pull/5681#discussion_r1141757812


##########
php/php.editor/test/unit/data/testfiles/actions/testNB4978/01/testNB4978_01.php.fixUses:
##########
@@ -23,8 +23,6 @@ declare (strict_types=1);
 
 namespace TestNamespace;
 
-use Foo\Foo\Foo;

Review Comment:
   It because there is no one real namespace in file or near to it, so if you debug UsesNamespaceCollector all dataItems names will be empty. So if I remove check for UsedNames you could put to selection anything like "Just\Want\It\To\Be\Added\To\Uses" and it would be added. For this test it would work as previously if we put file with \Foo\Foo\Foo near to the test file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists