You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by saltukalakus <gi...@git.apache.org> on 2014/07/31 14:52:47 UTC

[GitHub] trafficserver pull request: DEV: Quotation marks removed for numer...

GitHub user saltukalakus opened a pull request:

    https://github.com/apache/trafficserver/pull/100

    DEV: Quotation marks removed for numeric values

    In "Stats over Http" plugin, it is better if integer and floating values does not have quotation marks in JSON output. This way pluging JSON output works with loggers based on elasticsearch with minimal configuration. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/BATYD-Turksat/trafficserver master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/100.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #100
    
----
commit c76300867fd56a347b965653af082eb735f9378d
Author: Saltuk Alakus <sa...@gmail.com>
Date:   2014-07-31T12:41:49Z

    DEV: Quotation marks removed for numeric values

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request: DEV: Quotation marks removed for numer...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/trafficserver/pull/100


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request: DEV: Quotation marks removed for numer...

Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the pull request:

    https://github.com/apache/trafficserver/pull/100#issuecomment-55299885
  
    I have a patch that adds 2 new options to enable emitting JSON numbers, and to enable wrapping JSON numbers to int64. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request: DEV: Quotation marks removed for numer...

Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the pull request:

    https://github.com/apache/trafficserver/pull/100#issuecomment-52650438
  
    OK, this needs to be a plugin option then. Some consumers will expect javascript types and others will prefer richer integral types. The best thing to do here might be to serve 2 endpoints with the different semantics.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request: DEV: Quotation marks removed for numer...

Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the pull request:

    https://github.com/apache/trafficserver/pull/100#issuecomment-50781306
  
    Traffic Server counters are int64 ... can ElasticSearch deal with that, or is it constrained to JavaScript compatible numeric types?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request: DEV: Quotation marks removed for numer...

Posted by saltukalakus <gi...@git.apache.org>.
Github user saltukalakus commented on the pull request:

    https://github.com/apache/trafficserver/pull/100#issuecomment-52647362
  
    If follows Java convention. <a href="http://www.elasticsearch.org/guide/en/elasticsearch/reference/current/mapping-core-types.html">See link.</a> However you can configure each item with explicit mapping when required.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request: DEV: Quotation marks removed for numer...

Posted by saltukalakus <gi...@git.apache.org>.
Github user saltukalakus commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/100#discussion_r16420506
  
    --- Diff: lib/luajit ---
    @@ -1 +0,0 @@
    -Subproject commit 880ca300e8fb7b432b9d25ed377db2102e4cb63d
    --- End diff --
    
    Yes, it is by mistake. You can ignore this line.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request: DEV: Quotation marks removed for numer...

Posted by igalic <gi...@git.apache.org>.
Github user igalic commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/100#discussion_r16420184
  
    --- Diff: lib/luajit ---
    @@ -1 +0,0 @@
    -Subproject commit 880ca300e8fb7b432b9d25ed377db2102e4cb63d
    --- End diff --
    
    this should probably not be part of the commit


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---