You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "mnacharov (via GitHub)" <gi...@apache.org> on 2023/09/14 15:04:38 UTC

[GitHub] [airflow] mnacharov commented on a diff in pull request #34342: Chart: upgrade git-sync to v4.0.0+

mnacharov commented on code in PR #34342:
URL: https://github.com/apache/airflow/pull/34342#discussion_r1326100219


##########
airflow/providers/cncf/kubernetes/pod_template_file_examples/git_sync_template.yaml:
##########
@@ -26,21 +26,21 @@ metadata:
 spec:
   initContainers:
     - name: git-sync
-      image: "registry.k8s.io/git-sync/git-sync:v3.6.3"
+      image: "registry.k8s.io/git-sync/git-sync:v4.0.0"
       env:
-        - name: GIT_SYNC_BRANCH
+        - name: GITSYNC_REF

Review Comment:
   ok. As I can see, git-sync v4.0.0+ accept `GIT_SYNC_BRANCH` and `GIT_SYNC_REV` flags, they just deprecated, so I guess we can still use them for a some time



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org