You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "kgabryje (via GitHub)" <gi...@apache.org> on 2024/03/29 15:28:36 UTC
[PR] feat(explore): Clear temporal filter value [superset]
kgabryje opened a new pull request, #27788:
URL: https://github.com/apache/superset/pull/27788
### SUMMARY
Currently when there is 1 temporal filter added and user tries to remove it, we display a message saying that there must be at least 1 temporal filter in the chart. We use the same flow regardless if the filter has a value or not, so simply clearing the filter requires many additional clicks.
This PR improves that behaviour:
- if there's more than 1 temporal filter, remove the filter on "x" click
- if there's 1 temporal filter and it has a value other than "No filter", set the value to "No filter" on "x" click
- if there's 1 empty temporal filter, display a warning message
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
https://github.com/apache/superset/assets/15073128/ba3897ab-3005-4e9e-9d9a-47e9ebd8e29c
### TESTING INSTRUCTIONS
1. Go to explore and add multiple temporal filters with some values
2. Delete all but the last one
3. Try to delete the last one - instead of being removed, the filter should clear its value
4. Try to delete it again - a warning message should be displayed
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(explore): Clear temporal filter value [superset]
Posted by "yousoph (via GitHub)" <gi...@apache.org>.
yousoph commented on PR #27788:
URL: https://github.com/apache/superset/pull/27788#issuecomment-2035572917
> This seems a bit confusing... if we allow a temporal filter that says "No filter", why not allow having no filters? It seems like we're leaking an implementation detail to the user, where the API requires a filter (even if it says "No filter") so we require it in the UI.
Yeah, agreed with what @michael-s-molina mentioned that it's not quite ideal but we need to know what the temporal column is.
You're right that it is a little inconsistent when removing multiple filters but the idea was to remove a bit of friction from the user and reduce the frequency at which they see what feels like an error popup when the goal is to clear the filter values for now, until this flow is improved further.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(explore): Clear temporal filter value [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27788:
URL: https://github.com/apache/superset/pull/27788#issuecomment-2044451737
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(explore): Clear temporal filter value [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27788:
URL: https://github.com/apache/superset/pull/27788#issuecomment-2034677955
@kgabryje Ephemeral environment spinning up at http://35.163.223.205:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(explore): Clear temporal filter value [superset]
Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje closed pull request #27788: feat(explore): Clear temporal filter value
URL: https://github.com/apache/superset/pull/27788
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(explore): Clear temporal filter value [superset]
Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje merged PR #27788:
URL: https://github.com/apache/superset/pull/27788
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(explore): Clear temporal filter value [superset]
Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje commented on PR #27788:
URL: https://github.com/apache/superset/pull/27788#issuecomment-2034654651
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(explore): Clear temporal filter value [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #27788:
URL: https://github.com/apache/superset/pull/27788#issuecomment-2035487503
> This seems a bit confusing... if we allow a temporal filter that says "No filter", why not allow having no filters? It seems like we're leaking an implementation detail to the user, where the API requires a filter (even if it says "No filter") so we require it in the UI.
@betodealmeida You're correct. It is confusing. The problem is that currently we need to know what's the temporal column used in the chart when applying dashboard native filters. That's why it always need at least one temporal filter configured. We discussed this problem many times internally and with @kasiazjc and we're going to write a SIP to completely change how this works by augmenting native filters to correctly handle time filters and remove this quirkiness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(explore): Clear temporal filter value [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #27788:
URL: https://github.com/apache/superset/pull/27788#issuecomment-2027415406
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/27788?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `30.00000%` with `7 lines` in your changes are missing coverage. Please review.
> Project coverage is 69.83%. Comparing base [(`356b0d8`)](https://app.codecov.io/gh/apache/superset/commit/356b0d8ee56f42fe2de651b1a8ee08f1c4857172?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`6c92a14`)](https://app.codecov.io/gh/apache/superset/pull/27788?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
| [Files](https://app.codecov.io/gh/apache/superset/pull/27788?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../src/explore/components/ControlPanelsContainer.tsx](https://app.codecov.io/gh/apache/superset/pull/27788?src=pr&el=tree&filepath=superset-frontend%2Fsrc%2Fexplore%2Fcomponents%2FControlPanelsContainer.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sUGFuZWxzQ29udGFpbmVyLnRzeA==) | 12.50% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/27788?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #27788 +/- ##
=======================================
Coverage 69.82% 69.83%
=======================================
Files 1920 1920
Lines 75242 75248 +6
Branches 8423 8425 +2
=======================================
+ Hits 52538 52549 +11
+ Misses 20642 20637 -5
Partials 2062 2062
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/27788/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/27788/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.42% <30.00%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/27788?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(explore): Clear temporal filter value [superset]
Posted by "betodealmeida (via GitHub)" <gi...@apache.org>.
betodealmeida commented on PR #27788:
URL: https://github.com/apache/superset/pull/27788#issuecomment-2035456623
This seems a bit confusing... if we allow a temporal filter that says "No filter", why not allow having no filters? It seems like we're leaking an implementation detail to the user, where the API requires a filter (even if it says "No filter") so we require it in the UI.
It might be easier to allow having no filters, and simply sending "No filter" to the API if there are no filters, though ideally we'd fix this in the backend. Having the X do two different things — remove the filter or changing the filter time range depending on the number of filters — will confuse users.
cc: @yousoph
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org