[GitHub] spark pull request #16744: [SPARK-19405][STREAMING] Support for cross-accoun...

[srowen <gi...@git.apache.org>]

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16744#discussion_r99110527
  
    --- Diff: pom.xml ---
    @@ -146,6 +146,8 @@
         <avro.mapred.classifier>hadoop2</avro.mapred.classifier>
         <jets3t.version>0.7.1</jets3t.version>
         <aws.kinesis.client.version>1.6.2</aws.kinesis.client.version>
    +    <!-- Should be consistent with Kinesis client dependency -->
    +    <aws.java.sdk.version>1.10.61</aws.java.sdk.version>
    --- End diff --
    
    This is probably an ignorant question but is this the first and only time something depends on the AWS SDK here? I know we had discussions about the Kinesis client already because its license was problematic. Didn't it already depend on the AWS SDK and is the license OK? Worth re-checking this situation, if you would, as a second set of eyes would be useful.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org