You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by ty...@apache.org on 2023/04/03 09:03:39 UTC
[incubator-seatunnel] branch dev updated: [Hotfix][Connector-V2][Jdbc] Set default value to false of JdbcOption: generate_sink_sql (#4471)
This is an automated email from the ASF dual-hosted git repository.
tyrantlucifer pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-seatunnel.git
The following commit(s) were added to refs/heads/dev by this push:
new 7da11c2f4 [Hotfix][Connector-V2][Jdbc] Set default value to false of JdbcOption: generate_sink_sql (#4471)
7da11c2f4 is described below
commit 7da11c2f44809055e8d59f1cb86ad3957535ebb7
Author: Marvin <29...@qq.com>
AuthorDate: Mon Apr 3 17:03:29 2023 +0800
[Hotfix][Connector-V2][Jdbc] Set default value to false of JdbcOption: generate_sink_sql (#4471)
* Set default value to false of JdbcPotion: generate_sink_sql
* fix e2e config
---------
Co-authored-by: mcy <re...@163.com>
---
.../apache/seatunnel/connectors/seatunnel/jdbc/config/JdbcOptions.java | 2 +-
.../src/test/resources/sqlservercdc_to_console.conf | 2 ++
.../src/test/resources/jdbc_sink_auto_generate_sql.conf | 2 +-
.../src/test/resources/jdbc_sink_auto_generate_upsql_sql.conf | 1 +
.../src/test/resources/jdbc_sink_cdc_changelog.conf | 1 +
.../src/test/resources/kafkasource_canal_cdc_to_pgsql.conf | 1 +
6 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/config/JdbcOptions.java b/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/config/JdbcOptions.java
index a49b93bc6..d297fbc9e 100644
--- a/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/config/JdbcOptions.java
+++ b/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/config/JdbcOptions.java
@@ -79,7 +79,7 @@ public interface JdbcOptions {
Option<Boolean> GENERATE_SINK_SQL =
Options.key("generate_sink_sql")
.booleanType()
- .defaultValue(true)
+ .defaultValue(false)
.withDescription("generate sql using the database table");
Option<String> XA_DATA_SOURCE_CLASS_NAME =
diff --git a/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cdc-sqlserver-e2e/src/test/resources/sqlservercdc_to_console.conf b/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cdc-sqlserver-e2e/src/test/resources/sqlservercdc_to_console.conf
index 6dee20a17..6a3723631 100644
--- a/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cdc-sqlserver-e2e/src/test/resources/sqlservercdc_to_console.conf
+++ b/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cdc-sqlserver-e2e/src/test/resources/sqlservercdc_to_console.conf
@@ -50,6 +50,8 @@ sink {
url = "jdbc:sqlserver://sqlserver-host:1433;encrypt=false"
user = "sa"
password = "Password!"
+ generate_sink_sql = true
+ database = ""
table = "column_type_test.dbo.full_types_sink"
batch_size = 1
primary_keys = ["id"]
diff --git a/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-jdbc-e2e/connector-jdbc-e2e-part-1/src/test/resources/jdbc_sink_auto_generate_sql.conf b/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-jdbc-e2e/connector-jdbc-e2e-part-1/src/test/resources/jdbc_sink_auto_generate_sql.conf
index 33ec82209..a4c9dde49 100644
--- a/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-jdbc-e2e/connector-jdbc-e2e-part-1/src/test/resources/jdbc_sink_auto_generate_sql.conf
+++ b/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-jdbc-e2e/connector-jdbc-e2e-part-1/src/test/resources/jdbc_sink_auto_generate_sql.conf
@@ -53,7 +53,7 @@ sink {
url = "jdbc:postgresql://postgresql:5432/test?loggerLevel=OFF"
user = test
password = test
-
+ generate_sink_sql = true
database = test
table = "public.sink"
}
diff --git a/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-jdbc-e2e/connector-jdbc-e2e-part-1/src/test/resources/jdbc_sink_auto_generate_upsql_sql.conf b/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-jdbc-e2e/connector-jdbc-e2e-part-1/src/test/resources/jdbc_sink_auto_generate_upsql_sql.conf
index 3e5808c1d..87079ad1f 100644
--- a/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-jdbc-e2e/connector-jdbc-e2e-part-1/src/test/resources/jdbc_sink_auto_generate_upsql_sql.conf
+++ b/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-jdbc-e2e/connector-jdbc-e2e-part-1/src/test/resources/jdbc_sink_auto_generate_upsql_sql.conf
@@ -53,6 +53,7 @@ sink {
url = "jdbc:postgresql://postgresql:5432/test?loggerLevel=OFF"
user = test
password = test
+ generate_sink_sql = true
database = test
table = "public.sink"
primary_keys = ["user_id"]
diff --git a/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-jdbc-e2e/connector-jdbc-e2e-part-3/src/test/resources/jdbc_sink_cdc_changelog.conf b/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-jdbc-e2e/connector-jdbc-e2e-part-3/src/test/resources/jdbc_sink_cdc_changelog.conf
index 2d31ec4ab..5a4847617 100644
--- a/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-jdbc-e2e/connector-jdbc-e2e-part-3/src/test/resources/jdbc_sink_cdc_changelog.conf
+++ b/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-jdbc-e2e/connector-jdbc-e2e-part-3/src/test/resources/jdbc_sink_cdc_changelog.conf
@@ -64,6 +64,7 @@ sink {
url = "jdbc:postgresql://postgresql:5432/test?loggerLevel=OFF"
user = test
password = test
+ generate_sink_sql = true
database = test
table = "public.sink"
primary_keys = ["pk_id"]
diff --git a/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-kafka-e2e/src/test/resources/kafkasource_canal_cdc_to_pgsql.conf b/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-kafka-e2e/src/test/resources/kafkasource_canal_cdc_to_pgsql.conf
index 00bdcadbc..bc9c3f3c5 100644
--- a/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-kafka-e2e/src/test/resources/kafkasource_canal_cdc_to_pgsql.conf
+++ b/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-kafka-e2e/src/test/resources/kafkasource_canal_cdc_to_pgsql.conf
@@ -55,6 +55,7 @@ sink {
url = "jdbc:postgresql://postgresql:5432/test?loggerLevel=OFF"
user = test
password = test
+ generate_sink_sql = true
database = public
table = sink
primary_keys = ["id"]