You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openwebbeans.apache.org by Romain Manni-Bucau <rm...@apache.org> on 2020/11/21 15:24:05 UTC
Fwd: [openwebbeans] branch master updated: [OWB-1355]
OwbRequestContextController does not work with web contexts service
Hi everyone,
This small detail makes the Request scope controller (+ its interceptor) of
the spec working very well in standalone or with most of custom
contextsservice but not with our web one.
I think this can be worth a release to promote this part of the
specification which avoids several workaround or custom thread locals.
What do you think?
Anyone tempted to do the release (worse case I can probably run it next
week).
---------- Forwarded message ---------
De : <rm...@apache.org>
Date: sam. 21 nov. 2020 à 16:21
Subject: [openwebbeans] branch master updated: [OWB-1355]
OwbRequestContextController does not work with web contexts service
To: commits@openwebbeans.apache.org <co...@openwebbeans.apache.org>
This is an automated email from the ASF dual-hosted git repository.
rmannibucau pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openwebbeans.git
The following commit(s) were added to refs/heads/master by this push:
new b8ba652 [OWB-1355] OwbRequestContextController does not work with
web contexts service
b8ba652 is described below
commit b8ba6527144238606ca9cd640b9e11003dfee4d6
Author: Romain Manni-Bucau <rm...@gmail.com>
AuthorDate: Sat Nov 21 16:21:46 2020 +0100
[OWB-1355] OwbRequestContextController does not work with web contexts
service
---
.../apache/webbeans/context/control/OwbRequestContextController.java |
2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/webbeans-impl/src/main/java/org/apache/webbeans/context/control/OwbRequestContextController.java
b/webbeans-impl/src/main/java/org/apache/webbeans/context/control/OwbRequestContextController.java
index d48852b..3dd4383 100644
---
a/webbeans-impl/src/main/java/org/apache/webbeans/context/control/OwbRequestContextController.java
+++
b/webbeans-impl/src/main/java/org/apache/webbeans/context/control/OwbRequestContextController.java
@@ -40,7 +40,7 @@ public class OwbRequestContextController implements
RequestContextController
@Override
public boolean activate()
{
- final Context ctx =
contextsService.getCurrentContext(RequestScoped.class);
+ final Context ctx =
contextsService.getCurrentContext(RequestScoped.class, false);
if (ctx == null || !ctx.isActive())
{
contextsService.startContext(RequestScoped.class, null);