You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/02/15 03:33:41 UTC

[GitHub] [nifi] alopresto opened a new pull request #4057: NIFI-6927 Consolidate SSL context and trust managers for OkHttp on JDK9.

alopresto opened a new pull request #4057: NIFI-6927 Consolidate SSL context and trust managers for OkHttp on JDK9.
URL: https://github.com/apache/nifi/pull/4057
 
 
   Fixes name conflicts.
   Added SSLConfig interface and standard implementation.
   Added method to translate SSLContextService implementations to SSLConfig DTO for parsing by SSLContextFactory.
   Added nifi-security-utils dependency to nifi-ssl-context-service-api module.
   Removed unused SecurityStoreTypes.
   Refactored OkHttp client building code from distinct components to utility methods.
   Fixed checkstyle issues.
   Fixed NullPointerExceptions.
   Fixed additional test failures.
   Fixed keystore type case sensitivity.
   Fixed missing interface method implementations in test classes.
   
   Co-authored-by: Andy LoPresto <al...@apache.org>
   
   Thank you for submitting a contribution to Apache NiFi.
   
   Please provide a short description of the PR here:
   
   #### Description of PR
   
   _Extends the refactoring done by @natural in [PR 4047](https://github.com/apache/nifi/pull/4047) and includes (some) `SSLContextFactory` refactoring identified in [NIFI-1478](https://issues.apache.org/jira/browse/NIFI-1478)._
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
        in the commit message?
   
   - [x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `master`)?
   
   - [x] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
   
   ### For code changes:
   - [x] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
   - [x] Have you written or updated unit tests to verify your changes?
   - [ ] Have you verified that the full build is successful on both JDK 8 and JDK 11?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
   - [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
   - [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
   - [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [nifi] alopresto commented on issue #4057: NIFI-6927 Consolidate SSL context and trust managers for OkHttp on JDK9.

Posted by GitBox <gi...@apache.org>.
alopresto commented on issue #4057: NIFI-6927 Consolidate SSL context and trust managers for OkHttp on JDK9.
URL: https://github.com/apache/nifi/pull/4057#issuecomment-586549422
 
 
   I have a simple flow which uses `InvokeHttp` with a `StandardRestrictedSSLContextService` to connect to https://nifi.apache.org/download.html and retrieve the page content. 
   
   @natural please test this against your Elasticsearch instance as well. 
   
   [flow_20200214-192703_NIFI-6927-InvokeHTTP-SSL.xml.gz](https://github.com/apache/nifi/files/4207714/flow_20200214-192703_NIFI-6927-InvokeHTTP-SSL.xml.gz)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services