[jira] [Commented] (VCL-897) Simplify arguments accepted by grant_root_access subroutines

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/VCL-897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693652#comment-14693652 ] 

ASF subversion and git services commented on VCL-897:
-----------------------------------------------------

Commit 1695554 from [~arkurth] in branch 'vcl/trunk'
[ https://svn.apache.org/r1695554 ]

VCL-871
Updated OS.pm::create_text_file to ensure that text is added on a new line at the end of the file if called with the $append flag. This subroutine should correctly add newlines when necessary. Callers of append_text_file (which calls create_text_file) should not have to ensure a trailing newline exists in the string passed.

Removed trailing newline from the AllowUsers line appended to external_sshd_config in Linux.pm::grant_connect_method_access. It should no longer be needed.

Updated OS.pm::set_vcld_post_load_status to use create_text_file instead of echo.

VCL-896
Reworked and cleaned up Linux.pm::update_public_hostname. Added call to hostnamectl.  Removed Linux.pm::update_hostname_file which was using sed and echo instead of create_text_file.

VCL-897
Changed argument accepted by Linux.pm::grant_root_access to a simple string. Changed Linux.pm::create_user to only call grant_root_access if necessary.

Other
Added Linux.pm::install_package. This isn't currently being called but may be used in the future.

> Simplify arguments accepted by grant_root_access subroutines
> ------------------------------------------------------------
>
>                 Key: VCL-897
>                 URL: https://issues.apache.org/jira/browse/VCL-897
>             Project: VCL
>          Issue Type: Improvement
>          Components: vcld (backend)
>            Reporter: Andy Kurth
>            Assignee: Andy Kurth
>             Fix For: 2.5
>
>
> The {{grant_root_access}} subroutines in {{Linux.pm}} and {{Windows.pm}} accept a hash reference argument which must contain a _username_ key.  The username is the only piece of information {{grant_root_access}} needs.
> {{grant_root_access}} is also currently using a _root\_access_ key.  It makes no sense to call this subroutine and then have it check if it should have been called in the first place.  The caller should be responsible for this.
> The hash reference argument was presumably a result of copying and pasting the arguments accepted by its caller, the {{create_user}} subroutine which requires the other pieces of information contained in the hash reference.
> There is no point of passing information to {{grant_root_access}} which it doesn't need.  It would be better programming style to pass it a simple string containing the username.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)