You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Kristian Waagan (JIRA)" <ji...@apache.org> on 2010/08/10 10:21:16 UTC
[jira] Created: (DERBY-4764) Files with missing ASF license headers
Files with missing ASF license headers
--------------------------------------
Key: DERBY-4764
URL: https://issues.apache.org/jira/browse/DERBY-4764
Project: Derby
Issue Type: Bug
Components: Miscellaneous
Affects Versions: 10.7.0.0
Reporter: Kristian Waagan
Assignee: Kristian Waagan
There are some files (consisting of creative works) without license headers in the repository. Some files are also using a different text for the Apache License header then the other files.
I plan to add the license header after having verified that the files were uploaded to Jira with the grant license to ASF bullet ticked.
The list of files I have identified so far, grouped based on the assumed action required.
--- Add license header
java/testing/org/apache/derbyTesting/functionTests/tests/memory/TriggerTests.java
java/engine/org/apache/derby/impl/sql/catalog/XPLAINStatementDescriptor.java
java/engine/org/apache/derby/impl/sql/catalog/XPLAINScanPropsDescriptor.java
java/engine/org/apache/derby/impl/sql/catalog/XPLAINResultSetDescriptor.java
java/engine/org/apache/derby/impl/sql/catalog/XPLAINStatementTimingsDescriptor.java
java/engine/org/apache/derby/impl/sql/catalog/XPLAINSortPropsDescriptor.java
java/engine/org/apache/derby/impl/sql/catalog/XPLAINResultSetTimingsDescriptor.java
java/engine/org/apache/derby/impl/sql/catalog/XPLAINTableDescriptor.java
java/engine/org/apache/derby/impl/sql/execute/xplain/XPLAINSystemTableVisitor.java
java/engine/org/apache/derby/impl/sql/execute/xplain/XPLAINDefaultVisitor.java
java/engine/org/apache/derby/impl/sql/execute/xplain/XPLAINFactory.java
java/engine/org/apache/derby/impl/sql/execute/xplain/XPLAINUtil.java
java/engine/org/apache/derby/iapi/sql/execute/xplain/XPLAINFactoryIF.java
java/engine/org/apache/derby/iapi/sql/execute/xplain/XPLAINable.java
java/engine/org/apache/derby/iapi/sql/execute/xplain/XPLAINVisitor.java
java/tools/org/apache/derby/tools/PlanExporter.java
java/tools/org/apache/derby/impl/tools/planexporter/TreeNode.java
java/tools/org/apache/derby/impl/tools/planexporter/AccessDatabase.java
java/tools/org/apache/derby/impl/tools/planexporter/CreateHTMLFile.java
java/tools/org/apache/derby/impl/tools/planexporter/CreateXMLFile.java
--- Update license header
java/engine/org/apache/derby/impl/services/jmxnone/NoManagementService.java
java/engine/org/apache/derby/impl/services/jmx/JMXManagementService.java
java/engine/org/apache/derby/iapi/services/jmx/ManagementService.java
--- Consider adding header
java/shared/org/apache/derby/shared/common/sanity/SanityState.java
java/shared/org/apache/derby/shared/common/sanity/SanityState.tmpl
java/tools/org/apache/derby/impl/tools/planexporter/resources/advancedViewXSL.xsl
java/tools/org/apache/derby/impl/tools/planexporter/resources/vanilla_html.xsl
java/tools/org/apache/derby/impl/tools/planexporter/resources/advancedViewXSL2.xsl
The SanityState classes seem to come from somewhere. Does anyone have the history? Can we add the ASF license header?
The xsl files also look like creative works to me. Any objections on that?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DERBY-4764) Files with missing ASF license headers
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan closed DERBY-4764.
----------------------------------
Fix Version/s: 10.7.0.0
Resolution: Fixed
Closing issue.
> Files with missing ASF license headers
> --------------------------------------
>
> Key: DERBY-4764
> URL: https://issues.apache.org/jira/browse/DERBY-4764
> Project: Derby
> Issue Type: Bug
> Components: Miscellaneous
> Affects Versions: 10.7.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Fix For: 10.7.0.0
>
> Attachments: derby-4764-1a-license_headers_trunk.diff
>
>
> There are some files (consisting of creative works) without license headers in the repository. Some files are also using a different text for the Apache License header then the other files.
> I plan to add the license header after having verified that the files were uploaded to Jira with the grant license to ASF bullet ticked.
> The list of files I have identified so far, grouped based on the assumed action required.
> --- Add license header
> java/testing/org/apache/derbyTesting/functionTests/tests/memory/TriggerTests.java
> java/engine/org/apache/derby/impl/sql/catalog/XPLAINStatementDescriptor.java
> java/engine/org/apache/derby/impl/sql/catalog/XPLAINScanPropsDescriptor.java
> java/engine/org/apache/derby/impl/sql/catalog/XPLAINResultSetDescriptor.java
> java/engine/org/apache/derby/impl/sql/catalog/XPLAINStatementTimingsDescriptor.java
> java/engine/org/apache/derby/impl/sql/catalog/XPLAINSortPropsDescriptor.java
> java/engine/org/apache/derby/impl/sql/catalog/XPLAINResultSetTimingsDescriptor.java
> java/engine/org/apache/derby/impl/sql/catalog/XPLAINTableDescriptor.java
> java/engine/org/apache/derby/impl/sql/execute/xplain/XPLAINSystemTableVisitor.java
> java/engine/org/apache/derby/impl/sql/execute/xplain/XPLAINDefaultVisitor.java
> java/engine/org/apache/derby/impl/sql/execute/xplain/XPLAINFactory.java
> java/engine/org/apache/derby/impl/sql/execute/xplain/XPLAINUtil.java
> java/engine/org/apache/derby/iapi/sql/execute/xplain/XPLAINFactoryIF.java
> java/engine/org/apache/derby/iapi/sql/execute/xplain/XPLAINable.java
> java/engine/org/apache/derby/iapi/sql/execute/xplain/XPLAINVisitor.java
> java/tools/org/apache/derby/tools/PlanExporter.java
> java/tools/org/apache/derby/impl/tools/planexporter/TreeNode.java
> java/tools/org/apache/derby/impl/tools/planexporter/AccessDatabase.java
> java/tools/org/apache/derby/impl/tools/planexporter/CreateHTMLFile.java
> java/tools/org/apache/derby/impl/tools/planexporter/CreateXMLFile.java
> --- Update license header
> java/engine/org/apache/derby/impl/services/jmxnone/NoManagementService.java
> java/engine/org/apache/derby/impl/services/jmx/JMXManagementService.java
> java/engine/org/apache/derby/iapi/services/jmx/ManagementService.java
> --- Consider adding header
> java/shared/org/apache/derby/shared/common/sanity/SanityState.java
> java/shared/org/apache/derby/shared/common/sanity/SanityState.tmpl
> java/tools/org/apache/derby/impl/tools/planexporter/resources/advancedViewXSL.xsl
> java/tools/org/apache/derby/impl/tools/planexporter/resources/vanilla_html.xsl
> java/tools/org/apache/derby/impl/tools/planexporter/resources/advancedViewXSL2.xsl
> The SanityState classes seem to come from somewhere. Does anyone have the history? Can we add the ASF license header?
> The xsl files also look like creative works to me. Any objections on that?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4764) Files with missing ASF license
headers
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898097#action_12898097 ]
Kristian Waagan commented on DERBY-4764:
----------------------------------------
As noted under DERBY-4587, my changes to the XSL files broke the PlanExporter tool. The problem has been corrected under that issue (won't affect a backport, those files only exist in trunk at the moment).
> Files with missing ASF license headers
> --------------------------------------
>
> Key: DERBY-4764
> URL: https://issues.apache.org/jira/browse/DERBY-4764
> Project: Derby
> Issue Type: Bug
> Components: Miscellaneous
> Affects Versions: 10.7.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Attachments: derby-4764-1a-license_headers_trunk.diff
>
>
> There are some files (consisting of creative works) without license headers in the repository. Some files are also using a different text for the Apache License header then the other files.
> I plan to add the license header after having verified that the files were uploaded to Jira with the grant license to ASF bullet ticked.
> The list of files I have identified so far, grouped based on the assumed action required.
> --- Add license header
> java/testing/org/apache/derbyTesting/functionTests/tests/memory/TriggerTests.java
> java/engine/org/apache/derby/impl/sql/catalog/XPLAINStatementDescriptor.java
> java/engine/org/apache/derby/impl/sql/catalog/XPLAINScanPropsDescriptor.java
> java/engine/org/apache/derby/impl/sql/catalog/XPLAINResultSetDescriptor.java
> java/engine/org/apache/derby/impl/sql/catalog/XPLAINStatementTimingsDescriptor.java
> java/engine/org/apache/derby/impl/sql/catalog/XPLAINSortPropsDescriptor.java
> java/engine/org/apache/derby/impl/sql/catalog/XPLAINResultSetTimingsDescriptor.java
> java/engine/org/apache/derby/impl/sql/catalog/XPLAINTableDescriptor.java
> java/engine/org/apache/derby/impl/sql/execute/xplain/XPLAINSystemTableVisitor.java
> java/engine/org/apache/derby/impl/sql/execute/xplain/XPLAINDefaultVisitor.java
> java/engine/org/apache/derby/impl/sql/execute/xplain/XPLAINFactory.java
> java/engine/org/apache/derby/impl/sql/execute/xplain/XPLAINUtil.java
> java/engine/org/apache/derby/iapi/sql/execute/xplain/XPLAINFactoryIF.java
> java/engine/org/apache/derby/iapi/sql/execute/xplain/XPLAINable.java
> java/engine/org/apache/derby/iapi/sql/execute/xplain/XPLAINVisitor.java
> java/tools/org/apache/derby/tools/PlanExporter.java
> java/tools/org/apache/derby/impl/tools/planexporter/TreeNode.java
> java/tools/org/apache/derby/impl/tools/planexporter/AccessDatabase.java
> java/tools/org/apache/derby/impl/tools/planexporter/CreateHTMLFile.java
> java/tools/org/apache/derby/impl/tools/planexporter/CreateXMLFile.java
> --- Update license header
> java/engine/org/apache/derby/impl/services/jmxnone/NoManagementService.java
> java/engine/org/apache/derby/impl/services/jmx/JMXManagementService.java
> java/engine/org/apache/derby/iapi/services/jmx/ManagementService.java
> --- Consider adding header
> java/shared/org/apache/derby/shared/common/sanity/SanityState.java
> java/shared/org/apache/derby/shared/common/sanity/SanityState.tmpl
> java/tools/org/apache/derby/impl/tools/planexporter/resources/advancedViewXSL.xsl
> java/tools/org/apache/derby/impl/tools/planexporter/resources/vanilla_html.xsl
> java/tools/org/apache/derby/impl/tools/planexporter/resources/advancedViewXSL2.xsl
> The SanityState classes seem to come from somewhere. Does anyone have the history? Can we add the ASF license header?
> The xsl files also look like creative works to me. Any objections on that?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4764) Files with missing ASF license
headers
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897915#action_12897915 ]
Kristian Waagan commented on DERBY-4764:
----------------------------------------
I'm not sure whether to backport these changes. What to people think?
The changes made on trunk cannot be merged cleanly because some files don't exist on older branches, but I have a script that will insert the missing headers. One may also be able to manually tweak the merge.
> Files with missing ASF license headers
> --------------------------------------
>
> Key: DERBY-4764
> URL: https://issues.apache.org/jira/browse/DERBY-4764
> Project: Derby
> Issue Type: Bug
> Components: Miscellaneous
> Affects Versions: 10.7.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Attachments: derby-4764-1a-license_headers_trunk.diff
>
>
> There are some files (consisting of creative works) without license headers in the repository. Some files are also using a different text for the Apache License header then the other files.
> I plan to add the license header after having verified that the files were uploaded to Jira with the grant license to ASF bullet ticked.
> The list of files I have identified so far, grouped based on the assumed action required.
> --- Add license header
> java/testing/org/apache/derbyTesting/functionTests/tests/memory/TriggerTests.java
> java/engine/org/apache/derby/impl/sql/catalog/XPLAINStatementDescriptor.java
> java/engine/org/apache/derby/impl/sql/catalog/XPLAINScanPropsDescriptor.java
> java/engine/org/apache/derby/impl/sql/catalog/XPLAINResultSetDescriptor.java
> java/engine/org/apache/derby/impl/sql/catalog/XPLAINStatementTimingsDescriptor.java
> java/engine/org/apache/derby/impl/sql/catalog/XPLAINSortPropsDescriptor.java
> java/engine/org/apache/derby/impl/sql/catalog/XPLAINResultSetTimingsDescriptor.java
> java/engine/org/apache/derby/impl/sql/catalog/XPLAINTableDescriptor.java
> java/engine/org/apache/derby/impl/sql/execute/xplain/XPLAINSystemTableVisitor.java
> java/engine/org/apache/derby/impl/sql/execute/xplain/XPLAINDefaultVisitor.java
> java/engine/org/apache/derby/impl/sql/execute/xplain/XPLAINFactory.java
> java/engine/org/apache/derby/impl/sql/execute/xplain/XPLAINUtil.java
> java/engine/org/apache/derby/iapi/sql/execute/xplain/XPLAINFactoryIF.java
> java/engine/org/apache/derby/iapi/sql/execute/xplain/XPLAINable.java
> java/engine/org/apache/derby/iapi/sql/execute/xplain/XPLAINVisitor.java
> java/tools/org/apache/derby/tools/PlanExporter.java
> java/tools/org/apache/derby/impl/tools/planexporter/TreeNode.java
> java/tools/org/apache/derby/impl/tools/planexporter/AccessDatabase.java
> java/tools/org/apache/derby/impl/tools/planexporter/CreateHTMLFile.java
> java/tools/org/apache/derby/impl/tools/planexporter/CreateXMLFile.java
> --- Update license header
> java/engine/org/apache/derby/impl/services/jmxnone/NoManagementService.java
> java/engine/org/apache/derby/impl/services/jmx/JMXManagementService.java
> java/engine/org/apache/derby/iapi/services/jmx/ManagementService.java
> --- Consider adding header
> java/shared/org/apache/derby/shared/common/sanity/SanityState.java
> java/shared/org/apache/derby/shared/common/sanity/SanityState.tmpl
> java/tools/org/apache/derby/impl/tools/planexporter/resources/advancedViewXSL.xsl
> java/tools/org/apache/derby/impl/tools/planexporter/resources/vanilla_html.xsl
> java/tools/org/apache/derby/impl/tools/planexporter/resources/advancedViewXSL2.xsl
> The SanityState classes seem to come from somewhere. Does anyone have the history? Can we add the ASF license header?
> The xsl files also look like creative works to me. Any objections on that?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-4764) Files with missing ASF license headers
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan updated DERBY-4764:
-----------------------------------
Attachment: derby-4764-1a-license_headers_trunk.diff
Attached patch 'derby-4764-1a-license_headers_trunk.diff', and committed it to trunk with revision 984922.
I wasn't quite sure what to do about the "Class - " line in the XSL files, for now I only specified the base name (without extension). Feel free to change them if you feel like.
> Files with missing ASF license headers
> --------------------------------------
>
> Key: DERBY-4764
> URL: https://issues.apache.org/jira/browse/DERBY-4764
> Project: Derby
> Issue Type: Bug
> Components: Miscellaneous
> Affects Versions: 10.7.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Attachments: derby-4764-1a-license_headers_trunk.diff
>
>
> There are some files (consisting of creative works) without license headers in the repository. Some files are also using a different text for the Apache License header then the other files.
> I plan to add the license header after having verified that the files were uploaded to Jira with the grant license to ASF bullet ticked.
> The list of files I have identified so far, grouped based on the assumed action required.
> --- Add license header
> java/testing/org/apache/derbyTesting/functionTests/tests/memory/TriggerTests.java
> java/engine/org/apache/derby/impl/sql/catalog/XPLAINStatementDescriptor.java
> java/engine/org/apache/derby/impl/sql/catalog/XPLAINScanPropsDescriptor.java
> java/engine/org/apache/derby/impl/sql/catalog/XPLAINResultSetDescriptor.java
> java/engine/org/apache/derby/impl/sql/catalog/XPLAINStatementTimingsDescriptor.java
> java/engine/org/apache/derby/impl/sql/catalog/XPLAINSortPropsDescriptor.java
> java/engine/org/apache/derby/impl/sql/catalog/XPLAINResultSetTimingsDescriptor.java
> java/engine/org/apache/derby/impl/sql/catalog/XPLAINTableDescriptor.java
> java/engine/org/apache/derby/impl/sql/execute/xplain/XPLAINSystemTableVisitor.java
> java/engine/org/apache/derby/impl/sql/execute/xplain/XPLAINDefaultVisitor.java
> java/engine/org/apache/derby/impl/sql/execute/xplain/XPLAINFactory.java
> java/engine/org/apache/derby/impl/sql/execute/xplain/XPLAINUtil.java
> java/engine/org/apache/derby/iapi/sql/execute/xplain/XPLAINFactoryIF.java
> java/engine/org/apache/derby/iapi/sql/execute/xplain/XPLAINable.java
> java/engine/org/apache/derby/iapi/sql/execute/xplain/XPLAINVisitor.java
> java/tools/org/apache/derby/tools/PlanExporter.java
> java/tools/org/apache/derby/impl/tools/planexporter/TreeNode.java
> java/tools/org/apache/derby/impl/tools/planexporter/AccessDatabase.java
> java/tools/org/apache/derby/impl/tools/planexporter/CreateHTMLFile.java
> java/tools/org/apache/derby/impl/tools/planexporter/CreateXMLFile.java
> --- Update license header
> java/engine/org/apache/derby/impl/services/jmxnone/NoManagementService.java
> java/engine/org/apache/derby/impl/services/jmx/JMXManagementService.java
> java/engine/org/apache/derby/iapi/services/jmx/ManagementService.java
> --- Consider adding header
> java/shared/org/apache/derby/shared/common/sanity/SanityState.java
> java/shared/org/apache/derby/shared/common/sanity/SanityState.tmpl
> java/tools/org/apache/derby/impl/tools/planexporter/resources/advancedViewXSL.xsl
> java/tools/org/apache/derby/impl/tools/planexporter/resources/vanilla_html.xsl
> java/tools/org/apache/derby/impl/tools/planexporter/resources/advancedViewXSL2.xsl
> The SanityState classes seem to come from somewhere. Does anyone have the history? Can we add the ASF license header?
> The xsl files also look like creative works to me. Any objections on that?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4764) Files with missing ASF license
headers
Posted by "Rick Hillegas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12896880#action_12896880 ]
Rick Hillegas commented on DERBY-4764:
--------------------------------------
Hi Kristian,
SanityState.java is a generated file created from SanityState.tmpl by the "state" target in the master build file. That target just substitutes "true" or "false" for the @SANE@ literal. I think you will get what you want if you just add the Apache header to SanityState.tmpl. Thanks.
> Files with missing ASF license headers
> --------------------------------------
>
> Key: DERBY-4764
> URL: https://issues.apache.org/jira/browse/DERBY-4764
> Project: Derby
> Issue Type: Bug
> Components: Miscellaneous
> Affects Versions: 10.7.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
>
> There are some files (consisting of creative works) without license headers in the repository. Some files are also using a different text for the Apache License header then the other files.
> I plan to add the license header after having verified that the files were uploaded to Jira with the grant license to ASF bullet ticked.
> The list of files I have identified so far, grouped based on the assumed action required.
> --- Add license header
> java/testing/org/apache/derbyTesting/functionTests/tests/memory/TriggerTests.java
> java/engine/org/apache/derby/impl/sql/catalog/XPLAINStatementDescriptor.java
> java/engine/org/apache/derby/impl/sql/catalog/XPLAINScanPropsDescriptor.java
> java/engine/org/apache/derby/impl/sql/catalog/XPLAINResultSetDescriptor.java
> java/engine/org/apache/derby/impl/sql/catalog/XPLAINStatementTimingsDescriptor.java
> java/engine/org/apache/derby/impl/sql/catalog/XPLAINSortPropsDescriptor.java
> java/engine/org/apache/derby/impl/sql/catalog/XPLAINResultSetTimingsDescriptor.java
> java/engine/org/apache/derby/impl/sql/catalog/XPLAINTableDescriptor.java
> java/engine/org/apache/derby/impl/sql/execute/xplain/XPLAINSystemTableVisitor.java
> java/engine/org/apache/derby/impl/sql/execute/xplain/XPLAINDefaultVisitor.java
> java/engine/org/apache/derby/impl/sql/execute/xplain/XPLAINFactory.java
> java/engine/org/apache/derby/impl/sql/execute/xplain/XPLAINUtil.java
> java/engine/org/apache/derby/iapi/sql/execute/xplain/XPLAINFactoryIF.java
> java/engine/org/apache/derby/iapi/sql/execute/xplain/XPLAINable.java
> java/engine/org/apache/derby/iapi/sql/execute/xplain/XPLAINVisitor.java
> java/tools/org/apache/derby/tools/PlanExporter.java
> java/tools/org/apache/derby/impl/tools/planexporter/TreeNode.java
> java/tools/org/apache/derby/impl/tools/planexporter/AccessDatabase.java
> java/tools/org/apache/derby/impl/tools/planexporter/CreateHTMLFile.java
> java/tools/org/apache/derby/impl/tools/planexporter/CreateXMLFile.java
> --- Update license header
> java/engine/org/apache/derby/impl/services/jmxnone/NoManagementService.java
> java/engine/org/apache/derby/impl/services/jmx/JMXManagementService.java
> java/engine/org/apache/derby/iapi/services/jmx/ManagementService.java
> --- Consider adding header
> java/shared/org/apache/derby/shared/common/sanity/SanityState.java
> java/shared/org/apache/derby/shared/common/sanity/SanityState.tmpl
> java/tools/org/apache/derby/impl/tools/planexporter/resources/advancedViewXSL.xsl
> java/tools/org/apache/derby/impl/tools/planexporter/resources/vanilla_html.xsl
> java/tools/org/apache/derby/impl/tools/planexporter/resources/advancedViewXSL2.xsl
> The SanityState classes seem to come from somewhere. Does anyone have the history? Can we add the ASF license header?
> The xsl files also look like creative works to me. Any objections on that?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.