You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ma...@apache.org on 2024/06/28 19:45:44 UTC
(superset) branch master updated: chore(frontend): remove obsolete ESLint rules in tests (#29405)
This is an automated email from the ASF dual-hosted git repository.
maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new e274925b2a chore(frontend): remove obsolete ESLint rules in tests (#29405)
e274925b2a is described below
commit e274925b2a975165b4c22e87860075c90d7e4832
Author: Đỗ Trọng Hải <41...@users.noreply.github.com>
AuthorDate: Sat Jun 29 02:45:38 2024 +0700
chore(frontend): remove obsolete ESLint rules in tests (#29405)
Signed-off-by: hainenber <do...@gmail.com>
---
superset-frontend/src/SqlLab/actions/sqlLab.test.js | 1 -
superset-frontend/src/explore/actions/exploreActions.test.js | 1 -
.../src/explore/components/controls/CheckboxControl.test.tsx | 1 -
.../FilterControl/AdhocFilterControl/AdhocFilterControl.test.jsx | 1 -
.../FilterControl/AdhocFilterEditPopover/AdhocFilterEditPopover.test.jsx | 1 -
.../AdhocFilterEditPopoverSimpleTabContent.test.tsx | 1 -
.../MetricControl/AdhocMetricEditPopover/AdhocMetricEditPopover.test.jsx | 1 -
.../explore/components/controls/MetricControl/AdhocMetricOption.test.jsx | 1 -
.../components/controls/MetricControl/FilterDefinitionOption.test.jsx | 1 -
.../components/controls/MetricControl/MetricDefinitionValue.test.jsx | 1 -
.../explore/components/controls/MetricControl/MetricsControl.test.jsx | 1 -
superset-frontend/src/explore/components/controls/SelectControl.test.jsx | 1 -
.../src/explore/components/controls/TextAreaControl.test.jsx | 1 -
.../src/explore/components/controls/ViewportControl.test.jsx | 1 -
14 files changed, 14 deletions(-)
diff --git a/superset-frontend/src/SqlLab/actions/sqlLab.test.js b/superset-frontend/src/SqlLab/actions/sqlLab.test.js
index 11ab424512..f889d81ffb 100644
--- a/superset-frontend/src/SqlLab/actions/sqlLab.test.js
+++ b/superset-frontend/src/SqlLab/actions/sqlLab.test.js
@@ -16,7 +16,6 @@
* specific language governing permissions and limitations
* under the License.
*/
-/* eslint no-unused-expressions: 0 */
import sinon from 'sinon';
import fetchMock from 'fetch-mock';
import configureMockStore from 'redux-mock-store';
diff --git a/superset-frontend/src/explore/actions/exploreActions.test.js b/superset-frontend/src/explore/actions/exploreActions.test.js
index 12bbdce4e7..77c204cf3f 100644
--- a/superset-frontend/src/explore/actions/exploreActions.test.js
+++ b/superset-frontend/src/explore/actions/exploreActions.test.js
@@ -16,7 +16,6 @@
* specific language governing permissions and limitations
* under the License.
*/
-/* eslint-disable no-unused-expressions */
import { defaultState } from 'src/explore/store';
import exploreReducer from 'src/explore/reducers/exploreReducer';
import * as actions from 'src/explore/actions/exploreActions';
diff --git a/superset-frontend/src/explore/components/controls/CheckboxControl.test.tsx b/superset-frontend/src/explore/components/controls/CheckboxControl.test.tsx
index 84ba568225..9ad8f891e1 100644
--- a/superset-frontend/src/explore/components/controls/CheckboxControl.test.tsx
+++ b/superset-frontend/src/explore/components/controls/CheckboxControl.test.tsx
@@ -16,7 +16,6 @@
* specific language governing permissions and limitations
* under the License.
*/
-/* eslint-disable no-unused-expressions */
import { render, screen } from 'spec/helpers/testing-library';
import { ThemeProvider, supersetTheme } from '@superset-ui/core';
import CheckboxControl from 'src/explore/components/controls/CheckboxControl';
diff --git a/superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterControl/AdhocFilterControl.test.jsx b/superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterControl/AdhocFilterControl.test.jsx
index ffd2d17601..55f2ea7018 100644
--- a/superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterControl/AdhocFilterControl.test.jsx
+++ b/superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterControl/AdhocFilterControl.test.jsx
@@ -16,7 +16,6 @@
* specific language governing permissions and limitations
* under the License.
*/
-/* eslint-disable no-unused-expressions */
import sinon from 'sinon';
import { shallow } from 'enzyme';
import { supersetTheme } from '@superset-ui/core';
diff --git a/superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopover/AdhocFilterEditPopover.test.jsx b/superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopover/AdhocFilterEditPopover.test.jsx
index 594c20fd83..3a8e8d0745 100644
--- a/superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopover/AdhocFilterEditPopover.test.jsx
+++ b/superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopover/AdhocFilterEditPopover.test.jsx
@@ -16,7 +16,6 @@
* specific language governing permissions and limitations
* under the License.
*/
-/* eslint-disable no-unused-expressions */
import sinon from 'sinon';
import { shallow } from 'enzyme';
import Button from 'src/components/Button';
diff --git a/superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopoverSimpleTabContent/AdhocFilterEditPopoverSimpleTabContent.test.tsx b/superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopoverSimpleTabContent/AdhocFilterEditPopoverSimpleTabContent.test.tsx
index 05f1ad0fc7..1e352cc38d 100644
--- a/superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopoverSimpleTabContent/AdhocFilterEditPopoverSimpleTabContent.test.tsx
+++ b/superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopoverSimpleTabContent/AdhocFilterEditPopoverSimpleTabContent.test.tsx
@@ -16,7 +16,6 @@
* specific language governing permissions and limitations
* under the License.
*/
-/* eslint-disable no-unused-expressions */
import * as redux from 'react-redux';
import sinon from 'sinon';
import { shallow } from 'enzyme';
diff --git a/superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricEditPopover/AdhocMetricEditPopover.test.jsx b/superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricEditPopover/AdhocMetricEditPopover.test.jsx
index e51c14f2a6..06b8b8a9ee 100644
--- a/superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricEditPopover/AdhocMetricEditPopover.test.jsx
+++ b/superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricEditPopover/AdhocMetricEditPopover.test.jsx
@@ -16,7 +16,6 @@
* specific language governing permissions and limitations
* under the License.
*/
-/* eslint-disable no-unused-expressions */
import sinon from 'sinon';
import { shallow } from 'enzyme';
import { FormItem } from 'src/components/Form';
diff --git a/superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricOption.test.jsx b/superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricOption.test.jsx
index bf1b501ac1..1ef070de81 100644
--- a/superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricOption.test.jsx
+++ b/superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricOption.test.jsx
@@ -16,7 +16,6 @@
* specific language governing permissions and limitations
* under the License.
*/
-/* eslint-disable no-unused-expressions */
import sinon from 'sinon';
import { shallow } from 'enzyme';
diff --git a/superset-frontend/src/explore/components/controls/MetricControl/FilterDefinitionOption.test.jsx b/superset-frontend/src/explore/components/controls/MetricControl/FilterDefinitionOption.test.jsx
index fb920cb7c6..a1bbc1cb14 100644
--- a/superset-frontend/src/explore/components/controls/MetricControl/FilterDefinitionOption.test.jsx
+++ b/superset-frontend/src/explore/components/controls/MetricControl/FilterDefinitionOption.test.jsx
@@ -16,7 +16,6 @@
* specific language governing permissions and limitations
* under the License.
*/
-/* eslint-disable no-unused-expressions */
import { render, screen } from 'spec/helpers/testing-library';
import FilterDefinitionOption from 'src/explore/components/controls/MetricControl/FilterDefinitionOption';
import { AGGREGATES } from 'src/explore/constants';
diff --git a/superset-frontend/src/explore/components/controls/MetricControl/MetricDefinitionValue.test.jsx b/superset-frontend/src/explore/components/controls/MetricControl/MetricDefinitionValue.test.jsx
index 259220bb4b..3b51fcc508 100644
--- a/superset-frontend/src/explore/components/controls/MetricControl/MetricDefinitionValue.test.jsx
+++ b/superset-frontend/src/explore/components/controls/MetricControl/MetricDefinitionValue.test.jsx
@@ -16,7 +16,6 @@
* specific language governing permissions and limitations
* under the License.
*/
-/* eslint-disable no-unused-expressions */
import { shallow } from 'enzyme';
import { AGGREGATES } from 'src/explore/constants';
diff --git a/superset-frontend/src/explore/components/controls/MetricControl/MetricsControl.test.jsx b/superset-frontend/src/explore/components/controls/MetricControl/MetricsControl.test.jsx
index 1be8b2aa97..bfc7349107 100644
--- a/superset-frontend/src/explore/components/controls/MetricControl/MetricsControl.test.jsx
+++ b/superset-frontend/src/explore/components/controls/MetricControl/MetricsControl.test.jsx
@@ -16,7 +16,6 @@
* specific language governing permissions and limitations
* under the License.
*/
-/* eslint-disable no-unused-expressions */
import sinon from 'sinon';
import { shallow } from 'enzyme';
diff --git a/superset-frontend/src/explore/components/controls/SelectControl.test.jsx b/superset-frontend/src/explore/components/controls/SelectControl.test.jsx
index 4b38ef72b1..d86c334be1 100644
--- a/superset-frontend/src/explore/components/controls/SelectControl.test.jsx
+++ b/superset-frontend/src/explore/components/controls/SelectControl.test.jsx
@@ -16,7 +16,6 @@
* specific language governing permissions and limitations
* under the License.
*/
-/* eslint-disable no-unused-expressions */
import sinon from 'sinon';
import { shallow } from 'enzyme';
import { Select as SelectComponent } from 'src/components';
diff --git a/superset-frontend/src/explore/components/controls/TextAreaControl.test.jsx b/superset-frontend/src/explore/components/controls/TextAreaControl.test.jsx
index e77a693102..402c69934d 100644
--- a/superset-frontend/src/explore/components/controls/TextAreaControl.test.jsx
+++ b/superset-frontend/src/explore/components/controls/TextAreaControl.test.jsx
@@ -16,7 +16,6 @@
* specific language governing permissions and limitations
* under the License.
*/
-/* eslint-disable no-unused-expressions */
import sinon from 'sinon';
import { styledMount as mount } from 'spec/helpers/theming';
import { TextAreaEditor } from 'src/components/AsyncAceEditor';
diff --git a/superset-frontend/src/explore/components/controls/ViewportControl.test.jsx b/superset-frontend/src/explore/components/controls/ViewportControl.test.jsx
index d74612a610..282e39f6b1 100644
--- a/superset-frontend/src/explore/components/controls/ViewportControl.test.jsx
+++ b/superset-frontend/src/explore/components/controls/ViewportControl.test.jsx
@@ -16,7 +16,6 @@
* specific language governing permissions and limitations
* under the License.
*/
-/* eslint-disable no-unused-expressions */
import { styledMount as mount } from 'spec/helpers/theming';
import Popover from 'src/components/Popover';