[jira] [Commented] (HBASE-29707) Fix region cache % metrics miss calculation

["Hudson (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-29707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18038735#comment-18038735 ] 

Hudson commented on HBASE-29707:
--------------------------------

Results for branch master
	[build #1371 on builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1371/]: (x) *{color:red}-1 overall{color}*
----
details (if available):

(x) {color:red}-1 general checks{color}
-- For more information [see general report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1371/General_20Nightly_20Build_20Report/]








(x) {color:red}-1 jdk17 hadoop3 checks{color}
-- For more information [see jdk17 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1371/JDK17_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk17 hadoop 3.3.5 backward compatibility checks{color}
-- For more information [see jdk17 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1371/JDK17_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk17 hadoop 3.3.6 backward compatibility checks{color}
-- For more information [see jdk17 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1371/JDK17_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk17 hadoop 3.4.0 backward compatibility checks{color}
-- For more information [see jdk17 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1371/JDK17_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk17 hadoop 3.4.1 backward compatibility checks{color}
-- For more information [see jdk17 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1371/JDK17_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test for 3.3.5 {color}
(/) {color:green}+1 client integration test for 3.3.6 {color}
(/) {color:green}+1 client integration test for 3.4.0 {color}
(/) {color:green}+1 client integration test for 3.4.1 {color}
(/) {color:green}+1 client integration test for 3.4.2 {color}


> Fix region cache % metrics miss calculation
> -------------------------------------------
>
>                 Key: HBASE-29707
>                 URL: https://issues.apache.org/jira/browse/HBASE-29707
>             Project: HBase
>          Issue Type: Bug
>          Components: BucketCache
>            Reporter: Wellington Chevreuil
>            Assignee: Wellington Chevreuil
>            Priority: Major
>              Labels: pull-request-available
>
> HBASE-28246 has introduced this metric that tracks the percentage of regions data that is cached, displaying this info on the RS UI store file metrics tab. 
> Unfortunately, under the following scenarios, this metric can be miscalculated and display wrong information:
> 1) Region compactions: During compactions with cacheCompactedOnWrite set to true, we cache the new blocks written during compaction, which correctly updates the related metric, but once compaction is finished and compacted files have its readers closed, we are evicting the blocks but missing to decrease those from the metric.
> 2) Cache of hlinks pointing to files in archive: When caching an HLink for a file in the archive folder from a region that's still online, we are adding that file cached size to the original region, which is wrong, since the archived file blocks are not relevant for the original region, but to the region containing the link.
> In both cases, affected regions will show the “% Cache” metric beyond 100% on the Web UI, which can be misleading. Also, this metric is used by the CacheAwareLoadBalancer, and over counting region cache percentage can impact this balancer efficiency.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)