You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ignite.apache.org by Kozlov Maxim <dr...@gmail.com> on 2017/08/02 16:53:47 UTC

Add isPrimary() and isBackup() methods on CacheQueryEntryEvent

Igniters,

When you solved the 3878[1] ticket, two methods were added[2]: isPrimary() and isBackup() on the CacheQueryEntryEvent in a public API. Do you agree with this decision?

[1] https://issues.apache.org/jira/browse/IGNITE-3878 <https://issues.apache.org/jira/browse/IGNITE-3878>
[2] https://github.com/apache/ignite/pull/1393 <https://github.com/apache/ignite/pull/1393>

--
Best Regards,
Max K.

Re: Add isPrimary() and isBackup() methods on CacheQueryEntryEvent

Posted by Kozlov Maxim <dr...@gmail.com>.

Igniters,

What do you think about the new API?


> 3 авг. 2017 г., в 15:56, Kozlov Maxim <dr...@gmail.com> написал(а):
> 
> Guys, 
> 
> I'm sorry for the misunderstanding, I was tired at the end of the day :-)
> In the process of working on the task, I had to add 2 methods to the public interface.
> The first method is #isBackup(), it returns 'true' if cache is being updated on the backup node.
> The second method is #isPrimary(), it returns 'true' if cache is being updated on the primary node.
> Their main purpose is to show where a continuous query filter has been invoked.
> 
> Any thoughts about such solution?
> 
>> 3 авг. 2017 г., в 14:45, Anton Vinogradov <av...@gridgain.com> написал(а):
>> 
>> Folks,
>> 
>> As far as I see, Issue still in PatchAvailable state, what did you mean by
>> "solved"?
>> 
>> On Wed, Aug 2, 2017 at 8:01 PM, Kozlov Maxim <dr...@gmail.com> wrote:
>> 
>>> Sure.
>>> 
>>> CacheQueryEntryEvent:
>>> 
>>> public abstract boolean isBackup();
>>> public abstract boolean isPrimary();
>>> 
>>> 
>>>> 2 авг. 2017 г., в 19:56, Nikolai Tikhonov <nt...@apache.org>
>>> написал(а):
>>>> 
>>>> Max,
>>>> 
>>>> Thank you for your contribution! Could you share here what exactly was
>>>> added to interface?
>>>> 
>>>> On Wed, Aug 2, 2017 at 7:53 PM, Kozlov Maxim <dr...@gmail.com>
>>> wrote:
>>>> 
>>>>> Igniters,
>>>>> 
>>>>> When you solved the 3878[1] ticket, two methods were added[2]:
>>> isPrimary()
>>>>> and isBackup() on the CacheQueryEntryEvent in a public API. Do you agree
>>>>> with this decision?
>>>>> 
>>>>> [1] https://issues.apache.org/jira/browse/IGNITE-3878 <
>>>>> https://issues.apache.org/jira/browse/IGNITE-3878>
>>>>> [2] https://github.com/apache/ignite/pull/1393 <
>>> https://github.com/apache/
>>>>> ignite/pull/1393>
>>>>> 
>>>>> --
>>>>> Best Regards,
>>>>> Max K.
>>>>> 
>>>>> 
>>>>> 
>>>>> 
>>>>> 
>>> 
>>> --
>>> Best Regards,
>>> Max K.
>>> 
>>> 
>>> 
>>> 
>>> 
> 
> --
> Best Regards,
> Max K.
> 
> 
> 
> 

--
Best Regards,
Max K.

Re: Add isPrimary() and isBackup() methods on CacheQueryEntryEvent

Posted by Kozlov Maxim <dr...@gmail.com>.

Guys, 

I'm sorry for the misunderstanding, I was tired at the end of the day :-)
In the process of working on the task, I had to add 2 methods to the public interface.
The first method is #isBackup(), it returns 'true' if cache is being updated on the backup node.
The second method is #isPrimary(), it returns 'true' if cache is being updated on the primary node.
Their main purpose is to show where a continuous query filter has been invoked.

Any thoughts about such solution?

> 3 авг. 2017 г., в 14:45, Anton Vinogradov <av...@gridgain.com> написал(а):
> 
> Folks,
> 
> As far as I see, Issue still in PatchAvailable state, what did you mean by
> "solved"?
> 
> On Wed, Aug 2, 2017 at 8:01 PM, Kozlov Maxim <dr...@gmail.com> wrote:
> 
>> Sure.
>> 
>> CacheQueryEntryEvent:
>> 
>> public abstract boolean isBackup();
>> public abstract boolean isPrimary();
>> 
>> 
>>> 2 авг. 2017 г., в 19:56, Nikolai Tikhonov <nt...@apache.org>
>> написал(а):
>>> 
>>> Max,
>>> 
>>> Thank you for your contribution! Could you share here what exactly was
>>> added to interface?
>>> 
>>> On Wed, Aug 2, 2017 at 7:53 PM, Kozlov Maxim <dr...@gmail.com>
>> wrote:
>>> 
>>>> Igniters,
>>>> 
>>>> When you solved the 3878[1] ticket, two methods were added[2]:
>> isPrimary()
>>>> and isBackup() on the CacheQueryEntryEvent in a public API. Do you agree
>>>> with this decision?
>>>> 
>>>> [1] https://issues.apache.org/jira/browse/IGNITE-3878 <
>>>> https://issues.apache.org/jira/browse/IGNITE-3878>
>>>> [2] https://github.com/apache/ignite/pull/1393 <
>> https://github.com/apache/
>>>> ignite/pull/1393>
>>>> 
>>>> --
>>>> Best Regards,
>>>> Max K.
>>>> 
>>>> 
>>>> 
>>>> 
>>>> 
>> 
>> --
>> Best Regards,
>> Max K.
>> 
>> 
>> 
>> 
>> 

--
Best Regards,
Max K.

Re: Add isPrimary() and isBackup() methods on CacheQueryEntryEvent

Posted by Anton Vinogradov <av...@gridgain.com>.

Folks,

As far as I see, Issue still in PatchAvailable state, what did you mean by
"solved"?

On Wed, Aug 2, 2017 at 8:01 PM, Kozlov Maxim <dr...@gmail.com> wrote:

> Sure.
>
> CacheQueryEntryEvent:
>
> public abstract boolean isBackup();
> public abstract boolean isPrimary();
>
>
> > 2 авг. 2017 г., в 19:56, Nikolai Tikhonov <nt...@apache.org>
> написал(а):
> >
> > Max,
> >
> > Thank you for your contribution! Could you share here what exactly was
> > added to interface?
> >
> > On Wed, Aug 2, 2017 at 7:53 PM, Kozlov Maxim <dr...@gmail.com>
> wrote:
> >
> >> Igniters,
> >>
> >> When you solved the 3878[1] ticket, two methods were added[2]:
> isPrimary()
> >> and isBackup() on the CacheQueryEntryEvent in a public API. Do you agree
> >> with this decision?
> >>
> >> [1] https://issues.apache.org/jira/browse/IGNITE-3878 <
> >> https://issues.apache.org/jira/browse/IGNITE-3878>
> >> [2] https://github.com/apache/ignite/pull/1393 <
> https://github.com/apache/
> >> ignite/pull/1393>
> >>
> >> --
> >> Best Regards,
> >> Max K.
> >>
> >>
> >>
> >>
> >>
>
> --
> Best Regards,
> Max K.
>
>
>
>
>

Re: Add isPrimary() and isBackup() methods on CacheQueryEntryEvent

Posted by Kozlov Maxim <dr...@gmail.com>.

Sure.

CacheQueryEntryEvent:

public abstract boolean isBackup();
public abstract boolean isPrimary();


> 2 авг. 2017 г., в 19:56, Nikolai Tikhonov <nt...@apache.org> написал(а):
> 
> Max,
> 
> Thank you for your contribution! Could you share here what exactly was
> added to interface?
> 
> On Wed, Aug 2, 2017 at 7:53 PM, Kozlov Maxim <dr...@gmail.com> wrote:
> 
>> Igniters,
>> 
>> When you solved the 3878[1] ticket, two methods were added[2]: isPrimary()
>> and isBackup() on the CacheQueryEntryEvent in a public API. Do you agree
>> with this decision?
>> 
>> [1] https://issues.apache.org/jira/browse/IGNITE-3878 <
>> https://issues.apache.org/jira/browse/IGNITE-3878>
>> [2] https://github.com/apache/ignite/pull/1393 <https://github.com/apache/
>> ignite/pull/1393>
>> 
>> --
>> Best Regards,
>> Max K.
>> 
>> 
>> 
>> 
>> 

--
Best Regards,
Max K.

Re: Add isPrimary() and isBackup() methods on CacheQueryEntryEvent

Posted by Nikolai Tikhonov <nt...@apache.org>.

Max,

Thank you for your contribution! Could you share here what exactly was
added to interface?

On Wed, Aug 2, 2017 at 7:53 PM, Kozlov Maxim <dr...@gmail.com> wrote:

> Igniters,
>
> When you solved the 3878[1] ticket, two methods were added[2]: isPrimary()
> and isBackup() on the CacheQueryEntryEvent in a public API. Do you agree
> with this decision?
>
> [1] https://issues.apache.org/jira/browse/IGNITE-3878 <
> https://issues.apache.org/jira/browse/IGNITE-3878>
> [2] https://github.com/apache/ignite/pull/1393 <https://github.com/apache/
> ignite/pull/1393>
>
> --
> Best Regards,
> Max K.
>
>
>
>
>