You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "Maarten Bosteels (JIRA)" <ji...@apache.org> on 2007/06/26 16:33:26 UTC
[jira] Created: (DIRMINA-390) IoHandler.messageSent is not called
when FilterChain contains SSLFilter
IoHandler.messageSent is not called when FilterChain contains SSLFilter
-----------------------------------------------------------------------
Key: DIRMINA-390
URL: https://issues.apache.org/jira/browse/DIRMINA-390
Project: MINA
Issue Type: Bug
Components: Filter
Affects Versions: 1.1.0, 2.0.0-M1
Reporter: Maarten Bosteels
SSLFilter swallows too many messageSent events
When the FilterChain contains both SSLFilter and ProtocolCodecFilter, the IoHandler does not receive messageSent events.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRMINA-390) IoHandler.messageSent is not called
when FilterChain contains SSLFilter
Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12511025 ]
Trustin Lee commented on DIRMINA-390:
-------------------------------------
Thanks for the test cases first of all. :)
However, your patch doesn't seem to fix the root cause of the problem. SSLFilter.messageSent should be called with EncryptedWriteRequest, but it is not for now.
> IoHandler.messageSent is not called when FilterChain contains SSLFilter
> -----------------------------------------------------------------------
>
> Key: DIRMINA-390
> URL: https://issues.apache.org/jira/browse/DIRMINA-390
> Project: MINA
> Issue Type: Bug
> Components: Filter
> Affects Versions: 1.1.0
> Reporter: Maarten Bosteels
> Fix For: 1.1.1
>
> Attachments: SSLFilter.java.diff, SSLFilterTest.java, SSLFilterTest.java
>
>
> SSLFilter swallows too many messageSent events
> When the FilterChain contains both SSLFilter and ProtocolCodecFilter, the IoHandler does not receive messageSent events.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRMINA-390) IoHandler.messageSent is not called
when FilterChain contains SSLFilter
Posted by "Maarten Bosteels (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Maarten Bosteels updated DIRMINA-390:
-------------------------------------
Attachment: SSLFilter.java.diff
patch for 2.0
(to be checked by MINA guru of course)
> IoHandler.messageSent is not called when FilterChain contains SSLFilter
> -----------------------------------------------------------------------
>
> Key: DIRMINA-390
> URL: https://issues.apache.org/jira/browse/DIRMINA-390
> Project: MINA
> Issue Type: Bug
> Components: Filter
> Affects Versions: 1.1.0, 2.0.0-M1
> Reporter: Maarten Bosteels
> Attachments: SSLFilter.java.diff, SSLFilterTest.java, SSLFilterTest.java
>
>
> SSLFilter swallows too many messageSent events
> When the FilterChain contains both SSLFilter and ProtocolCodecFilter, the IoHandler does not receive messageSent events.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DIRMINA-390) IoHandler.messageSent is not called
when FilterChain contains SSLFilter
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lecharny closed DIRMINA-390.
-------------------------------------
> IoHandler.messageSent is not called when FilterChain contains SSLFilter
> -----------------------------------------------------------------------
>
> Key: DIRMINA-390
> URL: https://issues.apache.org/jira/browse/DIRMINA-390
> Project: MINA
> Issue Type: Bug
> Components: Filter
> Affects Versions: 1.0.3, 1.1.0
> Reporter: Maarten Bosteels
> Assignee: Trustin Lee
> Fix For: 1.0.4, 1.1.1
>
> Attachments: SSLFilter.java.diff, SSLFilterTest.java, SSLFilterTest.java
>
>
> SSLFilter swallows too many messageSent events
> When the FilterChain contains both SSLFilter and ProtocolCodecFilter, the IoHandler does not receive messageSent events.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DIRMINA-390) IoHandler.messageSent is not called
when FilterChain contains SSLFilter
Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Trustin Lee resolved DIRMINA-390.
---------------------------------
Resolution: Fixed
Fix Version/s: 1.0.4
Assignee: Trustin Lee
This issue happens when ProtocolCodecFilter and SSLFilter are used together. ProtocolCodecFilter writes an empty buffer to mark that the whole message has been written. AbstractIoFilterChain's filterWrite implementation was programmed to bypass all previous filters if an empty buffer is forwarded because empty buffers often causes malfunction of existing filters such as CompressionFilter. However, the workaround instead caused the buffer to bypass SSLFilter.
I removed the ugly workaround in AbstractIoFilterChain's filterWrite and made sure CompressionFilter is not affected because of the removal of the workaround (i.e. added empty buffer check code).
> IoHandler.messageSent is not called when FilterChain contains SSLFilter
> -----------------------------------------------------------------------
>
> Key: DIRMINA-390
> URL: https://issues.apache.org/jira/browse/DIRMINA-390
> Project: MINA
> Issue Type: Bug
> Components: Filter
> Affects Versions: 1.0.3, 1.1.0
> Reporter: Maarten Bosteels
> Assignee: Trustin Lee
> Fix For: 1.0.4, 1.1.1
>
> Attachments: SSLFilter.java.diff, SSLFilterTest.java, SSLFilterTest.java
>
>
> SSLFilter swallows too many messageSent events
> When the FilterChain contains both SSLFilter and ProtocolCodecFilter, the IoHandler does not receive messageSent events.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRMINA-390) IoHandler.messageSent is not called
when FilterChain contains SSLFilter
Posted by "Maarten Bosteels (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12511044 ]
Maarten Bosteels commented on DIRMINA-390:
------------------------------------------
Yes, I was afraid my patch was a bit too simplistic :-)
> IoHandler.messageSent is not called when FilterChain contains SSLFilter
> -----------------------------------------------------------------------
>
> Key: DIRMINA-390
> URL: https://issues.apache.org/jira/browse/DIRMINA-390
> Project: MINA
> Issue Type: Bug
> Components: Filter
> Affects Versions: 1.1.0
> Reporter: Maarten Bosteels
> Fix For: 1.1.1
>
> Attachments: SSLFilter.java.diff, SSLFilterTest.java, SSLFilterTest.java
>
>
> SSLFilter swallows too many messageSent events
> When the FilterChain contains both SSLFilter and ProtocolCodecFilter, the IoHandler does not receive messageSent events.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRMINA-390) IoHandler.messageSent is not called
when FilterChain contains SSLFilter
Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Trustin Lee updated DIRMINA-390:
--------------------------------
Fix Version/s: 1.1.1
Affects Version/s: (was: 2.0.0-M1)
> IoHandler.messageSent is not called when FilterChain contains SSLFilter
> -----------------------------------------------------------------------
>
> Key: DIRMINA-390
> URL: https://issues.apache.org/jira/browse/DIRMINA-390
> Project: MINA
> Issue Type: Bug
> Components: Filter
> Affects Versions: 1.1.0
> Reporter: Maarten Bosteels
> Fix For: 1.1.1
>
> Attachments: SSLFilter.java.diff, SSLFilterTest.java, SSLFilterTest.java
>
>
> SSLFilter swallows too many messageSent events
> When the FilterChain contains both SSLFilter and ProtocolCodecFilter, the IoHandler does not receive messageSent events.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRMINA-390) IoHandler.messageSent is not called
when FilterChain contains SSLFilter
Posted by "Maarten Bosteels (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Maarten Bosteels updated DIRMINA-390:
-------------------------------------
Attachment: SSLFilterTest.java
Testcase for 1.1
> IoHandler.messageSent is not called when FilterChain contains SSLFilter
> -----------------------------------------------------------------------
>
> Key: DIRMINA-390
> URL: https://issues.apache.org/jira/browse/DIRMINA-390
> Project: MINA
> Issue Type: Bug
> Components: Filter
> Affects Versions: 1.1.0, 2.0.0-M1
> Reporter: Maarten Bosteels
> Attachments: SSLFilterTest.java, SSLFilterTest.java
>
>
> SSLFilter swallows too many messageSent events
> When the FilterChain contains both SSLFilter and ProtocolCodecFilter, the IoHandler does not receive messageSent events.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRMINA-390) IoHandler.messageSent is not called
when FilterChain contains SSLFilter
Posted by "Maarten Bosteels (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Maarten Bosteels updated DIRMINA-390:
-------------------------------------
Attachment: SSLFilterTest.java
Test case for 2.0
> IoHandler.messageSent is not called when FilterChain contains SSLFilter
> -----------------------------------------------------------------------
>
> Key: DIRMINA-390
> URL: https://issues.apache.org/jira/browse/DIRMINA-390
> Project: MINA
> Issue Type: Bug
> Components: Filter
> Affects Versions: 1.1.0, 2.0.0-M1
> Reporter: Maarten Bosteels
> Attachments: SSLFilterTest.java
>
>
> SSLFilter swallows too many messageSent events
> When the FilterChain contains both SSLFilter and ProtocolCodecFilter, the IoHandler does not receive messageSent events.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRMINA-390) IoHandler.messageSent is not called
when FilterChain contains SSLFilter
Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRMINA-390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Trustin Lee updated DIRMINA-390:
--------------------------------
Affects Version/s: 1.0.3
> IoHandler.messageSent is not called when FilterChain contains SSLFilter
> -----------------------------------------------------------------------
>
> Key: DIRMINA-390
> URL: https://issues.apache.org/jira/browse/DIRMINA-390
> Project: MINA
> Issue Type: Bug
> Components: Filter
> Affects Versions: 1.0.3, 1.1.0
> Reporter: Maarten Bosteels
> Assignee: Trustin Lee
> Fix For: 1.0.4, 1.1.1
>
> Attachments: SSLFilter.java.diff, SSLFilterTest.java, SSLFilterTest.java
>
>
> SSLFilter swallows too many messageSent events
> When the FilterChain contains both SSLFilter and ProtocolCodecFilter, the IoHandler does not receive messageSent events.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.