You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gora.apache.org by lewismc <gi...@git.apache.org> on 2016/03/26 02:43:06 UTC
[GitHub] gora pull request: GORA-471 Datastore for Infinispan
GitHub user lewismc opened a pull request:
https://github.com/apache/gora/pull/59
GORA-471 Datastore for Infinispan
This PR addresses https://issues.apache.org/jira/browse/GORA-471
The issue was originally proposed over on https://github.com/leads-project/gora-infinispan/issues/1
Absolute Kudos to the people over at the LEEDS-PROJECT and also on the CLOUD computing paper they put together to describe how they are using this module for cool sh*t.
@otrack please check out this PR and see what you think. All I have done is smarten it up a bit e.g. include license headers on all relevant files.
The one issue, is that the dependency at https://github.com/leads-project/infinispan-avro needs to be pushed to Maven central or installed locally on every node that wish to use this module.
We need to work on pushing https://github.com/leads-project/infinispan-avro to Maven central before we can merge this pull request.
Kudos again to all authors of this work, this work is not mine.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lewismc/gora GORA-471
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/gora/pull/59.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #59
----
commit 8267561e52a02bf9faf70a24484aac105cdcc9d0
Author: Lewis John McGibbney <le...@jpl.nasa.gov>
Date: 2016-03-26T01:42:02Z
GORA-471 Datastore for Infinispan
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: GORA-471 Datastore for Infinispan
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the pull request:
https://github.com/apache/gora/pull/59#issuecomment-214849445
@otrack sounds excellent.
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: GORA-471 Datastore for Infinispan
Posted by otrack <gi...@git.apache.org>.
Github user otrack commented on the pull request:
https://github.com/apache/gora/pull/59#issuecomment-214831759
Hi @lewismc, In the current state, I have integrated everything and the tests are passing properly. What I would like, before submitting the changes (via a pull request), is to give an insight on how deploying the server part of infinispan-avro. There will be a link to this explanation in the README.md file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: GORA-471 Datastore for Infinispan
Posted by renato2099 <gi...@git.apache.org>.
Github user renato2099 commented on the pull request:
https://github.com/apache/gora/pull/59#issuecomment-214783552
Thanks @otrack ! Great work indeed!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: GORA-471 Datastore for Infinispan
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the pull request:
https://github.com/apache/gora/pull/59#issuecomment-214828104
hi @otrack I've committed the module to Gora master branch and also made an update to the dependency versions to accommodate the shift to 1.0 and 1.0.Final.
Thanks for push these up to Maven Central. Once the build stabilizes, if you are able to open any tickets over at https://issues.apache.org/jira/browse/GORA before sending any pull requests it would be greatly appreciated.
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: GORA-471 Datastore for Infinispan
Posted by renato2099 <gi...@git.apache.org>.
Github user renato2099 commented on the pull request:
https://github.com/apache/gora/pull/59#issuecomment-205292664
Really cool for sure :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: GORA-471 Datastore for Infinispan
Posted by otrack <gi...@git.apache.org>.
Github user otrack commented on the pull request:
https://github.com/apache/gora/pull/59#issuecomment-214763012
Once this version is merged, I can do a few modifications; namely, (i) changing infinispan-avro to the now publicly released 1.0.Final, (ii) smoothing the README file and (iii) adding some instructions about how to start an ISPN server easily.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: GORA-471 Datastore for Infinispan
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the pull request:
https://github.com/apache/gora/pull/59#issuecomment-214782904
Hi @otrack nice, thanks. Good work on getting the infinispan-avro dependency pushed to Central.
I've committed this branch to master, if you could help to stabilize it would be appreciated.
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: GORA-471 Datastore for Infinispan
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/gora/pull/59
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---