You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by CMoH <gi...@git.apache.org> on 2015/11/10 20:08:55 UTC
[GitHub] incubator-brooklyn pull request: [BROOKLYN-183] Fix karaf package ...
GitHub user CMoH opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1019
[BROOKLYN-183] Fix karaf package wiring for brooklyn-core
For some reason the `brooklyn-core` bundle still imports `org.apache.felix.framework`, even if the actual code was moved to `brooklyn-rt-felix` and excluded from `brooklyn-core`'s imports.
This PR addresses this issue.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/CMoH/incubator-brooklyn karaf-container-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/1019.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1019
----
commit f0cadbabcef00aad8b3663d14685fea5591097a3
Author: Ciprian Ciubotariu <ch...@gmx.net>
Date: 2015-11-06T10:42:03Z
[BROOKLYN-183] Ignore bundle import of apache felix
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: [BROOKLYN-183] Fix karaf package ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/1019
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: [BROOKLYN-183] Fix karaf package ...
Posted by hzbarcea <gi...@git.apache.org>.
Github user hzbarcea commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1019#issuecomment-155651327
This is more of a workaround, but good enough for now. I think there's a bit more refactoring required.
Tested, karaf starts properly now and brooklyn-core is installed properly:
````
karaf@brooklyn()> feature:list | grep brooklyn
brooklyn-utils-common | 0.9.0.SNAPSHOT | | Started | org.apache.brooklyn-0.9.0-SNAPSHOT | Brooklyn Common Utils
brooklyn-utils-groovy | 0.9.0.SNAPSHOT | | Uninstalled | org.apache.brooklyn-0.9.0-SNAPSHOT | Brooklyn Groovy Utils
brooklyn-api | 0.9.0.SNAPSHOT | | Started | org.apache.brooklyn-0.9.0-SNAPSHOT | Brooklyn API
brooklyn-core | 0.9.0.SNAPSHOT | x | Started | org.apache.brooklyn-0.9.0-SNAPSHOT | Brooklyn Core
brooklyn-commands | 0.9.0.SNAPSHOT | | Uninstalled | org.apache.brooklyn-0.9.0-SNAPSHOT | Brooklyn Shell Commands
```
Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---