You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@singa.apache.org by GitBox <gi...@apache.org> on 2020/01/29 13:50:31 UTC
[GitHub] [singa-doc] joddiy opened a new pull request #2: update onnx,
add tiny_yolo_v2
joddiy opened a new pull request #2: update onnx, add tiny_yolo_v2
URL: https://github.com/apache/singa-doc/pull/2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [singa-doc] nudles merged pull request #2: update onnx,
add tiny_yolo_v2
Posted by GitBox <gi...@apache.org>.
nudles merged pull request #2: update onnx, add tiny_yolo_v2
URL: https://github.com/apache/singa-doc/pull/2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [singa-doc] joddiy commented on a change in pull request #2: update
onnx, add tiny_yolo_v2
Posted by GitBox <gi...@apache.org>.
joddiy commented on a change in pull request #2: update onnx, add tiny_yolo_v2
URL: https://github.com/apache/singa-doc/pull/2#discussion_r380439473
##########
File path: docs-site/website/versioned_docs/version-2.0.0/onnx.md
##########
@@ -1,7 +1,6 @@
---
-id: version-2.0.0-onnx
+id: onnx
title: ONNX
-original_id: onnx
Review comment:
Hi, @FeynmanDNA , sorry for late, just fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [singa-doc] FeynmanDNA commented on a change in pull request #2:
update onnx, add tiny_yolo_v2
Posted by GitBox <gi...@apache.org>.
FeynmanDNA commented on a change in pull request #2: update onnx, add tiny_yolo_v2
URL: https://github.com/apache/singa-doc/pull/2#discussion_r372422424
##########
File path: docs-site/website/versioned_docs/version-2.0.0/onnx.md
##########
@@ -1,7 +1,6 @@
---
-id: version-2.0.0-onnx
Review comment:
@joddiy hi for versioned_docs you have to keep the predix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [singa-doc] FeynmanDNA commented on a change in pull request #2:
update onnx, add tiny_yolo_v2
Posted by GitBox <gi...@apache.org>.
FeynmanDNA commented on a change in pull request #2: update onnx, add tiny_yolo_v2
URL: https://github.com/apache/singa-doc/pull/2#discussion_r372422740
##########
File path: docs-site/website/versioned_docs/version-2.0.0/onnx.md
##########
@@ -1,7 +1,6 @@
---
-id: version-2.0.0-onnx
+id: onnx
title: ONNX
-original_id: onnx
Review comment:
@joddiy same here, for versioned_docs, you need to keep the `original_id`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [singa-doc] joddiy commented on a change in pull request #2: update
onnx, add tiny_yolo_v2
Posted by GitBox <gi...@apache.org>.
joddiy commented on a change in pull request #2: update onnx, add tiny_yolo_v2
URL: https://github.com/apache/singa-doc/pull/2#discussion_r380439423
##########
File path: docs-site/website/versioned_docs/version-2.0.0/onnx.md
##########
@@ -1,7 +1,6 @@
---
-id: version-2.0.0-onnx
Review comment:
Hi, @FeynmanDNA , sorry for late, just fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [singa-doc] nudles commented on a change in pull request #2: update
onnx, add tiny_yolo_v2
Posted by GitBox <gi...@apache.org>.
nudles commented on a change in pull request #2: update onnx, add tiny_yolo_v2
URL: https://github.com/apache/singa-doc/pull/2#discussion_r381052217
##########
File path: docs-site/website/versioned_docs/version-2.0.0/onnx.md
##########
@@ -1,6 +1,7 @@
---
-id: onnx
+id: version-2.0.0-onnx
Review comment:
yes. version 2.0.0 is already fixed. all new files or updates will be in v2.1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [singa-doc] FeynmanDNA commented on a change in pull request #2:
update onnx, add tiny_yolo_v2
Posted by GitBox <gi...@apache.org>.
FeynmanDNA commented on a change in pull request #2: update onnx, add tiny_yolo_v2
URL: https://github.com/apache/singa-doc/pull/2#discussion_r380447719
##########
File path: docs-site/website/versioned_docs/version-2.0.0/onnx.md
##########
@@ -1,6 +1,7 @@
---
-id: onnx
+id: version-2.0.0-onnx
Review comment:
@joddiy hi, if i understand prof wang's suggestion, we can ignore the update for `versioned_docs` for v2.0.0, as this update only applies to v2.0+
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [singa-doc] nudles commented on a change in pull request #2: update
onnx, add tiny_yolo_v2
Posted by GitBox <gi...@apache.org>.
nudles commented on a change in pull request #2: update onnx, add tiny_yolo_v2
URL: https://github.com/apache/singa-doc/pull/2#discussion_r372795269
##########
File path: docs-site/website/versioned_docs/version-2.0.0/onnx.md
##########
@@ -1,7 +1,6 @@
---
-id: version-2.0.0-onnx
+id: onnx
Review comment:
I think we do not neet to duplicate the documentation into versioned_docs/ as this documentation will be available in v2.1. The code is now in singa:dev.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [singa-doc] joddiy commented on a change in pull request #2: update
onnx, add tiny_yolo_v2
Posted by GitBox <gi...@apache.org>.
joddiy commented on a change in pull request #2: update onnx, add tiny_yolo_v2
URL: https://github.com/apache/singa-doc/pull/2#discussion_r380439536
##########
File path: docs-site/website/versioned_docs/version-2.0.0/onnx.md
##########
@@ -1,7 +1,6 @@
---
-id: version-2.0.0-onnx
+id: onnx
Review comment:
@FeynmanDNA do you have any idea about this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services