[GitHub] [incubator-superset] DiggidyDave opened a new pull request #8085: Add LogConfigurator, and add logging for CSV export

[GitBox <gi...@apache.org>]

DiggidyDave opened a new pull request #8085: Add LogConfigurator, and add logging for CSV export
URL: https://github.com/apache/incubator-superset/pull/8085
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [X] Enhancement (new features, refinement)
   - [ ] Refactor
   - [X] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   
   - Added analytic event logging for CSV exports (including num rows, database info, etc).
   - Added `LOG_CONFIGURATOR` config option, and `DefaultLogConfigurator` as default to keep current behavior. This allows local installation config to add handlers etc to take action based on logged events.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   I tested locally, and there is a test to exercise the basic mechanism.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   @betodealmeida @mistercrunch 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org