You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "pitrou (via GitHub)" <gi...@apache.org> on 2023/12/07 11:26:54 UTC

Re: [PR] ARROW-17081: [Java][Datasets] Move JNI build configuration from cpp/ to java/ [arrow]

pitrou commented on code in PR #13911:
URL: https://github.com/apache/arrow/pull/13911#discussion_r1418811551


##########
cpp/CMakeLists.txt:
##########
@@ -851,6 +864,9 @@ add_dependencies(arrow_test_dependencies toolchain-tests)
 if(ARROW_STATIC_LINK_LIBS)
   add_dependencies(arrow_dependencies ${ARROW_STATIC_LINK_LIBS})
   if(ARROW_HDFS OR ARROW_ORC)
+    if(Protobuf_SOURCE STREQUAL "SYSTEM")

Review Comment:
   @kou This seems to require protobuf when HDFS is enabled, is there any reason for it? Is it a mistake?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org