You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Erik Krogen (JIRA)" <ji...@apache.org> on 2016/09/27 18:18:20 UTC
[jira] [Comment Edited] (HDFS-10896) Move lock logging logic from
FSNamesystem into FSNamesystemLock
[ https://issues.apache.org/jira/browse/HDFS-10896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15527007#comment-15527007 ]
Erik Krogen edited comment on HDFS-10896 at 9/27/16 6:18 PM:
-------------------------------------------------------------
Attaching v002 patch that rebases on top of HDFS-10713 and also fixes the Findbugs / checkstyle / whitespace / unit test / asflicense issues
was (Author: xkrogen):
Attaching v002 patch that rebases on top of HDFS-10713 and also fixes the Findbugs / checkstyle / whitespace / unit test issues
> Move lock logging logic from FSNamesystem into FSNamesystemLock
> ---------------------------------------------------------------
>
> Key: HDFS-10896
> URL: https://issues.apache.org/jira/browse/HDFS-10896
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Reporter: Erik Krogen
> Assignee: Erik Krogen
> Labels: logging, namenode
> Attachments: HDFS-10896.000.patch, HDFS-10896.001.patch, HDFS-10896.002.patch
>
>
> There are a number of tickets (HDFS-10742, HDFS-10817, HDFS-10713, this subtask's story HDFS-10475) which are adding/improving logging/metrics around the {{FSNamesystemLock}}. All of this is done in {{FSNamesystem}} right now, which is polluting the namesystem with ThreadLocal variables, timing counters, etc. which are only relevant to the lock itself and the number of these increases as the logging/metrics become more sophisticated. It would be best to move these all into FSNamesystemLock to keep the metrics/logging tied directly to the item of interest.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org