You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by zh...@apache.org on 2020/09/11 04:39:59 UTC

[incubator-mxnet] branch master updated: [PIP] add build target in cmake for osx compat (#19110)

This is an automated email from the ASF dual-hosted git repository.

zhasheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git


The following commit(s) were added to refs/heads/master by this push:
     new 95e1814  [PIP] add build target in cmake for osx compat (#19110)
95e1814 is described below

commit 95e1814ba5e0458fa854951d69f658366dcb7e12
Author: Sheng Zha <sz...@users.noreply.github.com>
AuthorDate: Thu Sep 10 21:38:38 2020 -0700

    [PIP] add build target in cmake for osx compat (#19110)
    
    * add build target in cmake for osx compat
    
    * update wheel tags
---
 tools/pip/setup.py             | 7 ++++++-
 tools/staticbuild/build_lib.sh | 6 +++++-
 2 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/tools/pip/setup.py b/tools/pip/setup.py
index 1c1c11e..9ba17c4 100644
--- a/tools/pip/setup.py
+++ b/tools/pip/setup.py
@@ -26,8 +26,13 @@ import shutil
 import platform
 
 if platform.system() == 'Linux':
-    sys.argv.append('--universal')
+    sys.argv.append('--python-tag')
+    sys.argv.append('py3')
     sys.argv.append('--plat-name=manylinux2014_x86_64')
+elif platform.system() == 'Darwin':
+    sys.argv.append('--python-tag')
+    sys.argv.append('py3')
+    sys.argv.append('--plat-name=macosx_10_13_x86_64')
 
 from setuptools import setup, find_packages
 from setuptools.dist import Distribution
diff --git a/tools/staticbuild/build_lib.sh b/tools/staticbuild/build_lib.sh
index 4eaf06c..ec23ac7 100755
--- a/tools/staticbuild/build_lib.sh
+++ b/tools/staticbuild/build_lib.sh
@@ -30,7 +30,11 @@ git submodule update --init --recursive || true
 
 # Build libmxnet.so
 rm -rf build; mkdir build; cd build
-cmake -GNinja -C $cmake_config -DCMAKE_PREFIX_PATH=${DEPS_PATH} -DCMAKE_FIND_ROOT_PATH=${DEPS_PATH} ..
+cmake -GNinja -C $cmake_config \
+      -DCMAKE_PREFIX_PATH=${DEPS_PATH} \
+      -DCMAKE_FIND_ROOT_PATH=${DEPS_PATH} \
+      -DCMAKE_OSX_DEPLOYMENT_TARGET=10.13 \
+      ..
 ninja
 cd -