[GitHub] ankit0811 commented on a change in pull request #6828: Kill Hadoop MR task on kill of Hadoop ingestion task

[GitBox <gi...@apache.org>]

ankit0811 commented on a change in pull request #6828: Kill Hadoop MR task on kill of Hadoop ingestion task 
URL: https://github.com/apache/incubator-druid/pull/6828#discussion_r248433075
 
 

 ##########
 File path: core/src/main/java/org/apache/druid/indexer/Jobby.java
 ##########
 @@ -30,6 +30,17 @@
 {
   boolean run();
 
+  /**
+   *
+   * @return A string represtenting the jobId of the actual MR job.
+   * Run method is now divided into two parts. The first one being submitAndGetHadoopJobId which just submits the job and returns the job ID
+   * Run then monitors this job for completion
+   */
+  default String submitAndGetHadoopJobId()
 
 Review comment:
   Thanks @jihoonson 
   That was a miss from my side
   I see DeterminePartitionJob basically runs 2 job 
   1. `determine_partitions_groupby`
   2. `determine_partitions_dimselection`
   
   Is it alright to split this into two separate method and then handle their job Id in JobHelper.singleRunJob() bu casting the job 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org