You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by we...@apache.org on 2019/01/17 05:50:07 UTC

[arrow] branch master updated: ARROW-4276: [Release] Remove needless Bintray authentication

This is an automated email from the ASF dual-hosted git repository.

wesm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/master by this push:
     new 50a2ca3  ARROW-4276: [Release] Remove needless Bintray authentication
50a2ca3 is described below

commit 50a2ca300417d58a4baca1f7b1c815137423a520
Author: Kouhei Sutou <ko...@clear-code.com>
AuthorDate: Wed Jan 16 23:49:52 2019 -0600

    ARROW-4276: [Release] Remove needless Bintray authentication
    
    "Get Version Files" https://bintray.com/docs/api/#_get_version_files
    doesn't require authentication.
    
    Author: Kouhei Sutou <ko...@clear-code.com>
    
    Closes #3415 from kou/release-verify-binary-remove-auth and squashes the following commits:
    
    8267cbbaa <Kouhei Sutou>  Remove needless Bintray authentication
---
 dev/release/verify-release-candidate.sh | 19 ++++---------------
 1 file changed, 4 insertions(+), 15 deletions(-)

diff --git a/dev/release/verify-release-candidate.sh b/dev/release/verify-release-candidate.sh
index de7dc18..944cabe 100755
--- a/dev/release/verify-release-candidate.sh
+++ b/dev/release/verify-release-candidate.sh
@@ -96,9 +96,6 @@ bintray() {
   echo "${command} ${url}" 1>&2
   curl \
     --fail \
-    --basic \
-    --user "${BINTRAY_USER}:${BINTRAY_PASSWORD}" \
-    --header "Content-Type: application/json" \
     --request ${command} \
     ${url} \
     "$@" | \
@@ -110,12 +107,10 @@ download_bintray_files() {
 
   local version_name=${VERSION}-rc${RC_NUMBER}
 
-  local files=$(
-    bintray \
-      GET /packages/${BINTRAY_REPOSITORY}/${target}-rc/versions/${version_name}/files | \
-      jq -r ".[].path")
-
-  for file in ${files}; do
+  bintray \
+    GET /packages/${BINTRAY_REPOSITORY}/${target}-rc/versions/${version_name}/files | \
+      jq -r ".[].path" | \
+      while read file; do
     mkdir -p "$(dirname ${file})"
     curl \
       --fail \
@@ -380,12 +375,6 @@ if [ "$ARTIFACT" == "source" ]; then
   test_integration
   test_rust
 else
-  if [ -z "${BINTRAY_PASSWORD}" ]; then
-    echo "BINTRAY_PASSWORD is empty"
-    exit 1
-  fi
-
-  : ${BINTRAY_USER:=$USER}
   : ${BINTRAY_REPOSITORY:=apache/arrow}
 
   verify_binary_artifacts