[GitHub] [helix] junkaixue commented on a diff in pull request #2452: Fixing the ZkServer.start() to just check for free port when starting ZK

["junkaixue (via GitHub)" <gi...@apache.org>]

junkaixue commented on code in PR #2452:
URL: https://github.com/apache/helix/pull/2452#discussion_r1170385924


##########
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/NetworkUtil.java:
##########
@@ -22,77 +22,14 @@
 import java.io.IOException;
 import java.net.ConnectException;
 import java.net.InetAddress;
-import java.net.NetworkInterface;
 import java.net.Socket;
 import java.net.SocketException;
 import java.net.UnknownHostException;
-import java.util.Enumeration;
-import java.util.HashSet;
-import java.util.Set;
 
 public class NetworkUtil {
 
     public final static String OVERWRITE_HOSTNAME_SYSTEM_PROPERTY = "zkclient.hostname.overwritten";
 
-    public static String[] getLocalHostNames() {

Review Comment:
   Delete public API is not allowed in open source project. Even if we are not using it in another of our code, it will be dangerous that open source users may use it.
   
   Please keep it here, if no place to use this API in our code, you can annotate with @Deprecated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org