[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #614: Compile lua by C++ compilers to avoid memory leaks

[GitBox <gi...@apache.org>]

PragmaTwice commented on PR #614:
URL: https://github.com/apache/incubator-kvrocks/pull/614#issuecomment-1143039074

   > It is a common usage to specify `CMAKE_CXX_COMPILER` before build e.g. `cmake .. -DCMAKE_CXX_COMPILER=/some/path/some-g++`, so I think using `CXX` may lead to different compilers in one build. I think we can use `try_compile` to workaround it: if it is in osx and `try_compile(a code snippet with <assert.h>)` fail, we will use `CXX`, otherwise we use `CMAKE_CXX_COMPILER` to keep C++ compiler unchanged. These logics are easy to implement in cmake : )
   
   Done :tada:


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org