You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/07 15:01:29 UTC
[GitHub] [spark] MaxGekk opened a new pull request #29968: [SPARK-26499][SQL][FOLLOWUP] Print the loading provider exception starting from the INFO level
MaxGekk opened a new pull request #29968:
URL: https://github.com/apache/spark/pull/29968
### What changes were proposed in this pull request?
1. Don't print the exception in the error message while loading a built-in provider.
2. Print the exception starting from the INFO level.
### Why are the changes needed?
To avoid "noise" in logs while running tests. Currently, logs are blown up:
```
org.apache.spark.sql.execution.datasources.jdbc.connection.ConnectionProvider: Loading of the provider failed with the exception:
java.util.ServiceConfigurationError: org.apache.spark.sql.jdbc.JdbcConnectionProvider: Provider org.apache.spark.sql.execution.datasources.jdbc.connection.IntentionallyFaultyConnectionProvider could not be instantiated
at java.util.ServiceLoader.fail(ServiceLoader.java:232)
at java.util.ServiceLoader.access$100(ServiceLoader.java:185)
at java.util.ServiceLoader$LazyIterator.nextService(ServiceLoader.java:384)
at java.util.ServiceLoader$LazyIterator.next(ServiceLoader.java:404)
at java.util.ServiceLoader$1.next(ServiceLoader.java:480)
at org.apache.spark.sql.execution.datasources.jdbc.connection.ConnectionProvider$.loadProviders(ConnectionProvider.scala:41)
...
at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.IllegalArgumentException: Intentional Exception
at org.apache.spark.sql.execution.datasources.jdbc.connection.IntentionallyFaultyConnectionProvider.<init>(IntentionallyFaultyConnectionProvider.scala:26)
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
at java.lang.Class.newInstance(Class.java:442)
at java.util.ServiceLoader$LazyIterator.nextService(ServiceLoader.java:380)
```
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
By running:
```
$ build/sbt "sql/test:testOnly org.apache.spark.sql.execution.datasources.v2.jdbc.JDBCTableCatalogSuite"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29968: [SPARK-26499][SQL][FOLLOWUP] Print the loading provider exception starting from the INFO level
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29968:
URL: https://github.com/apache/spark/pull/29968#issuecomment-704997071
**[Test build #129515 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129515/testReport)** for PR 29968 at commit [`27d4fbf`](https://github.com/apache/spark/commit/27d4fbfe0adbb25556596ae0a13cf1e019cc98e5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29968: [SPARK-32001][SQL][FOLLOWUP] Print the loading provider exception starting from the INFO level
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29968:
URL: https://github.com/apache/spark/pull/29968#issuecomment-705266886
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29968: [SPARK-32001][SQL][FOLLOWUP] Print the loading provider exception starting from the INFO level
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29968:
URL: https://github.com/apache/spark/pull/29968#issuecomment-705266886
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29968: [SPARK-26499][SQL][FOLLOWUP] Print the loading provider exception starting from the INFO level
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29968:
URL: https://github.com/apache/spark/pull/29968#issuecomment-705156946
**[Test build #129515 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129515/testReport)** for PR 29968 at commit [`27d4fbf`](https://github.com/apache/spark/commit/27d4fbfe0adbb25556596ae0a13cf1e019cc98e5).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #29968: [SPARK-26499][SQL][FOLLOWUP] Print the loading provider exception starting from the INFO level
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #29968:
URL: https://github.com/apache/spark/pull/29968#issuecomment-705200576
Actually, this is a follow up of https://github.com/apache/spark/pull/29024#issuecomment-702514012 which was merged recently. My bad, I copy-pasted wrong JIRA id :-E
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29968: [SPARK-26499][SQL][FOLLOWUP] Print the loading provider exception starting from the INFO level
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29968:
URL: https://github.com/apache/spark/pull/29968#issuecomment-705199818
This is Apache Spark git repo. `force` push is not a good practice here~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29968: [SPARK-26499][SQL][FOLLOWUP] Print the loading provider exception starting from the INFO level
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29968:
URL: https://github.com/apache/spark/pull/29968#issuecomment-705187485
My bad. I missed that SPARK-26499 is very old commit.
@MaxGekk . For next time, please use a different JIRA id. `FOLLOWUP` doesn't make much sense for old commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #29968: [SPARK-26499][SQL][FOLLOWUP] Print the loading provider exception starting from the INFO level
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #29968:
URL: https://github.com/apache/spark/pull/29968#issuecomment-705196228
ohh, yes. @dongjoon-hyun Can't you edit the commit message in the master? git should allow that. Sorry.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29968: [SPARK-26499][SQL][FOLLOWUP] Print the loading provider exception starting from the INFO level
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29968:
URL: https://github.com/apache/spark/pull/29968#issuecomment-705039582
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29968: [SPARK-32001][SQL][FOLLOWUP] Print the loading provider exception starting from the INFO level
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29968:
URL: https://github.com/apache/spark/pull/29968#issuecomment-705170674
**[Test build #129529 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129529/testReport)** for PR 29968 at commit [`042a80b`](https://github.com/apache/spark/commit/042a80b9a44a7dd6ce03c6e803debbb917289893).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29968: [SPARK-32001][SQL][FOLLOWUP] Print the loading provider exception starting from the INFO level
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29968:
URL: https://github.com/apache/spark/pull/29968#issuecomment-705266631
**[Test build #129529 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129529/testReport)** for PR 29968 at commit [`042a80b`](https://github.com/apache/spark/commit/042a80b9a44a7dd6ce03c6e803debbb917289893).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29968: [SPARK-32001][SQL][FOLLOWUP] Print the loading provider exception starting from the INFO level
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29968:
URL: https://github.com/apache/spark/pull/29968#issuecomment-705266896
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129529/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #29968: [SPARK-26499][SQL][FOLLOWUP] Print the loading provider exception starting from the INFO level
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #29968:
URL: https://github.com/apache/spark/pull/29968#issuecomment-704998924
I print the exception starting from the INFO level because WARN is on by default in tests, and the exception is still printed when:
```Scala
logWarning(s"Failed to load built in provider.", t)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29968: [SPARK-26499][SQL][FOLLOWUP] Print the loading provider exception starting from the INFO level
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29968:
URL: https://github.com/apache/spark/pull/29968#issuecomment-705201065
My bad, too. :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk edited a comment on pull request #29968: [SPARK-26499][SQL][FOLLOWUP] Print the loading provider exception starting from the INFO level
Posted by GitBox <gi...@apache.org>.
MaxGekk edited a comment on pull request #29968:
URL: https://github.com/apache/spark/pull/29968#issuecomment-705200576
Actually, this is a follow up of https://github.com/apache/spark/pull/29024#issuecomment-702514012 which was merged recently. My bad, I copy-pasted wrong JIRA id :-E . Let me change it at least in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29968: [SPARK-26499][SQL][FOLLOWUP] Print the loading provider exception starting from the INFO level
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29968:
URL: https://github.com/apache/spark/pull/29968#issuecomment-705199962
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34134/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29968: [SPARK-26499][SQL][FOLLOWUP] Print the loading provider exception starting from the INFO level
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #29968:
URL: https://github.com/apache/spark/pull/29968#discussion_r501279886
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/ConnectionProvider.scala
##########
@@ -43,7 +43,8 @@ private[jdbc] object ConnectionProvider extends Logging {
providers += provider
} catch {
case t: Throwable =>
- logError(s"Failed to load built in provider.", t)
+ logError("Failed to load built in provider.")
Review comment:
Maybe, could you update line 42 together?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29968: [SPARK-26499][SQL][FOLLOWUP] Print the loading provider exception starting from the INFO level
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29968:
URL: https://github.com/apache/spark/pull/29968#issuecomment-705039582
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29968: [SPARK-26499][SQL][FOLLOWUP] Print the loading provider exception starting from the INFO level
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29968:
URL: https://github.com/apache/spark/pull/29968#issuecomment-705192154
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34134/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29968: [SPARK-26499][SQL][FOLLOWUP] Print the loading provider exception starting from the INFO level
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29968:
URL: https://github.com/apache/spark/pull/29968#issuecomment-705158199
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #29968: [SPARK-26499][SQL][FOLLOWUP] Print the loading provider exception starting from the INFO level
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #29968:
URL: https://github.com/apache/spark/pull/29968
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29968: [SPARK-26499][SQL][FOLLOWUP] Print the loading provider exception starting from the INFO level
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29968:
URL: https://github.com/apache/spark/pull/29968#issuecomment-705027684
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34120/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29968: [SPARK-26499][SQL][FOLLOWUP] Print the loading provider exception starting from the INFO level
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29968:
URL: https://github.com/apache/spark/pull/29968#issuecomment-705170674
**[Test build #129529 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129529/testReport)** for PR 29968 at commit [`042a80b`](https://github.com/apache/spark/commit/042a80b9a44a7dd6ce03c6e803debbb917289893).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29968: [SPARK-26499][SQL][FOLLOWUP] Print the loading provider exception starting from the INFO level
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #29968:
URL: https://github.com/apache/spark/pull/29968#discussion_r501279436
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/ConnectionProvider.scala
##########
@@ -43,7 +43,8 @@ private[jdbc] object ConnectionProvider extends Logging {
providers += provider
} catch {
case t: Throwable =>
- logError(s"Failed to load built in provider.", t)
+ logError("Failed to load built in provider.")
Review comment:
`built in` -> `built-in`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29968: [SPARK-26499][SQL][FOLLOWUP] Print the loading provider exception starting from the INFO level
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29968:
URL: https://github.com/apache/spark/pull/29968#issuecomment-705200003
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on pull request #29968: [SPARK-26499][SQL][FOLLOWUP] Print the loading provider exception starting from the INFO level
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on pull request #29968:
URL: https://github.com/apache/spark/pull/29968#issuecomment-705003115
Not sure what others think but I'm totally fine with just simply printing the whole stuff w/ INFO level (don't insist to the ERROR level at all). But this is fine too. Others?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29968: [SPARK-26499][SQL][FOLLOWUP] Print the loading provider exception starting from the INFO level
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29968:
URL: https://github.com/apache/spark/pull/29968#issuecomment-705200003
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on pull request #29968: [SPARK-26499][SQL][FOLLOWUP] Print the loading provider exception starting from the INFO level
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on pull request #29968:
URL: https://github.com/apache/spark/pull/29968#issuecomment-705005984
Not mentioned that the direction is good. The tests are generating too much trash.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29968: [SPARK-26499][SQL][FOLLOWUP] Print the loading provider exception starting from the INFO level
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29968:
URL: https://github.com/apache/spark/pull/29968#issuecomment-705158199
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29968: [SPARK-26499][SQL][FOLLOWUP] Print the loading provider exception starting from the INFO level
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29968:
URL: https://github.com/apache/spark/pull/29968#issuecomment-705039559
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34120/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29968: [SPARK-26499][SQL][FOLLOWUP] Print the loading provider exception starting from the INFO level
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29968:
URL: https://github.com/apache/spark/pull/29968#issuecomment-704997071
**[Test build #129515 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129515/testReport)** for PR 29968 at commit [`27d4fbf`](https://github.com/apache/spark/commit/27d4fbfe0adbb25556596ae0a13cf1e019cc98e5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org