You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "danny0405 (via GitHub)" <gi...@apache.org> on 2023/05/06 04:28:49 UTC
[GitHub] [hudi] danny0405 opened a new pull request, #8649: [HUDI-6185] Too many logs in the ExternalSpillableMap
danny0405 opened a new pull request, #8649:
URL: https://github.com/apache/hudi/pull/8649
### Change Logs
Introduced by https://github.com/apache/hudi/pull/6632.
The current code logs for each record when the map had been spilled. It caused deluge of loggings.
### Impact
no impact
### Risk level (write none, low medium or high below)
none
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8649: [HUDI-6185] Too many logs in the ExternalSpillableMap
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8649:
URL: https://github.com/apache/hudi/pull/8649#issuecomment-1537063301
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3fbafb674339bb1e296fe8827996a84cf16fff19",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16880",
"triggerID" : "3fbafb674339bb1e296fe8827996a84cf16fff19",
"triggerType" : "PUSH"
}, {
"hash" : "e3ac89167ce3d4813ab7a3a1fed03a50a36e6e92",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e3ac89167ce3d4813ab7a3a1fed03a50a36e6e92",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3fbafb674339bb1e296fe8827996a84cf16fff19 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16880)
* e3ac89167ce3d4813ab7a3a1fed03a50a36e6e92 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8649: [HUDI-6185] Too many logs in the ExternalSpillableMap
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8649:
URL: https://github.com/apache/hudi/pull/8649#issuecomment-1537054542
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3fbafb674339bb1e296fe8827996a84cf16fff19",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16880",
"triggerID" : "3fbafb674339bb1e296fe8827996a84cf16fff19",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3fbafb674339bb1e296fe8827996a84cf16fff19 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16880)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #8649: [HUDI-6185] Too many logs in the ExternalSpillableMap
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #8649:
URL: https://github.com/apache/hudi/pull/8649#issuecomment-1537101000
This test is known to be flaky: https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=16882&view=logs&j=dcedfe73-9485-5cc5-817a-73b61fc5dcb0&t=746585d8-b50a-55c3-26c5-517d93af9934&l=33921, would merge it soon ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8649: [HUDI-6185] Too many logs in the ExternalSpillableMap
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8649:
URL: https://github.com/apache/hudi/pull/8649#issuecomment-1537064752
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3fbafb674339bb1e296fe8827996a84cf16fff19",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16880",
"triggerID" : "3fbafb674339bb1e296fe8827996a84cf16fff19",
"triggerType" : "PUSH"
}, {
"hash" : "e3ac89167ce3d4813ab7a3a1fed03a50a36e6e92",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16882",
"triggerID" : "e3ac89167ce3d4813ab7a3a1fed03a50a36e6e92",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3fbafb674339bb1e296fe8827996a84cf16fff19 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16880)
* e3ac89167ce3d4813ab7a3a1fed03a50a36e6e92 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16882)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #8649: [HUDI-6185] Too many logs in the ExternalSpillableMap
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #8649:
URL: https://github.com/apache/hudi/pull/8649#discussion_r1186640829
##########
hudi-common/src/main/java/org/apache/hudi/common/util/collection/ExternalSpillableMap.java:
##########
@@ -202,28 +202,20 @@ public R get(Object key) {
@Override
public R put(T key, R value) {
- if (this.currentInMemoryMapSize >= maxInMemorySizeInBytes || inMemoryMap.size() % NUMBER_OF_RECORDS_TO_ESTIMATE_PAYLOAD_SIZE == 0) {
- long tmpEstimatedPayloadSize = (long) (this.estimatedPayloadSize * 0.9
- + (keySizeEstimator.sizeEstimate(key) + valueSizeEstimator.sizeEstimate(value)) * 0.1);
Review Comment:
This line is also a mistake, because it can trigger for the 1st record with `estimatedPayloadSize` as `0`, it then causes all the estimation of payload size far smaller than the real size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8649: [HUDI-6185] Too many logs in the ExternalSpillableMap
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8649:
URL: https://github.com/apache/hudi/pull/8649#issuecomment-1537053060
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3fbafb674339bb1e296fe8827996a84cf16fff19",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3fbafb674339bb1e296fe8827996a84cf16fff19",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3fbafb674339bb1e296fe8827996a84cf16fff19 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8649: [HUDI-6185] Too many logs in the ExternalSpillableMap
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8649:
URL: https://github.com/apache/hudi/pull/8649#issuecomment-1537095748
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3fbafb674339bb1e296fe8827996a84cf16fff19",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16880",
"triggerID" : "3fbafb674339bb1e296fe8827996a84cf16fff19",
"triggerType" : "PUSH"
}, {
"hash" : "e3ac89167ce3d4813ab7a3a1fed03a50a36e6e92",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16882",
"triggerID" : "e3ac89167ce3d4813ab7a3a1fed03a50a36e6e92",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e3ac89167ce3d4813ab7a3a1fed03a50a36e6e92 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16882)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 merged pull request #8649: [HUDI-6185] Too many logs in the ExternalSpillableMap
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #8649:
URL: https://github.com/apache/hudi/pull/8649
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org