You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/01/09 21:45:08 UTC

[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #425: HDDS-2863. BindException in TestSCMRestart

adoroszlai opened a new pull request #425: HDDS-2863. BindException in TestSCMRestart
URL: https://github.com/apache/hadoop-ozone/pull/425
 
 
   ## What changes were proposed in this pull request?
   
   Recon exposes SCM-like RPC endpoint on (possibly) different port than SCM. However, when the RPC server [updates the config with the actual address](https://github.com/apache/hadoop-ozone/blob/046a06f02783da516179ee8d8d1bed862d22f78d/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMDatanodeProtocolServer.java#L166-L168) after startup, it does so using the SCM-specific config key.  It should use the Recon-specific one.
   
   https://issues.apache.org/jira/browse/HDDS-2863
   
   ## How was this patch tested?
   
   [Successful execution](https://github.com/adoroszlai/hadoop-ozone/runs/382069628) on the branch where integration tests are enabled:
   
   ```
   [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 33.547 s - in org.apache.hadoop.hdds.scm.pipeline.TestSCMRestart
   ```
   
   CI run (without integratiion tests) on top of master: https://github.com/adoroszlai/hadoop-ozone/runs/382180979

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org


[GitHub] [hadoop-ozone] avijayanhwx commented on issue #425: HDDS-2863. BindException in TestSCMRestart

Posted by GitBox <gi...@apache.org>.
avijayanhwx commented on issue #425: HDDS-2863. BindException in TestSCMRestart
URL: https://github.com/apache/hadoop-ozone/pull/425#issuecomment-572771330
 
 
   LGTM +1. Thanks for fixing this @adoroszlai.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org


[GitHub] [hadoop-ozone] bharatviswa504 merged pull request #425: HDDS-2863. BindException in TestSCMRestart

Posted by GitBox <gi...@apache.org>.
bharatviswa504 merged pull request #425: HDDS-2863. BindException in TestSCMRestart
URL: https://github.com/apache/hadoop-ozone/pull/425
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org


[GitHub] [hadoop-ozone] adoroszlai commented on issue #425: HDDS-2863. BindException in TestSCMRestart

Posted by GitBox <gi...@apache.org>.
adoroszlai commented on issue #425: HDDS-2863. BindException in TestSCMRestart
URL: https://github.com/apache/hadoop-ozone/pull/425#issuecomment-572907540
 
 
   Thanks @avijayanhwx for the review, and @bharatviswa504 for review and commit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org