You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stratos.apache.org by Vishanth <gi...@git.apache.org> on 2015/04/30 12:46:21 UTC

[GitHub] stratos pull request: Validate application definition to have grou...

GitHub user Vishanth opened a pull request:

    https://github.com/apache/stratos/pull/292

    Validate application definition to have group with unique aliases

    This is to validate the application definition to have group with unique aliases.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Vishanth/stratos validate-alias

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/stratos/pull/292.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #292
    
----
commit f8f9f7190956aef6f93a44f94f8641de12263914
Author: Vishanth <vi...@gmail.com>
Date:   2015-04-30T10:43:52Z

    Validate application definition to have group with unique aliases

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] stratos pull request: Validate application definition to have grou...

Posted by Vishanth <gi...@git.apache.org>.
Github user Vishanth commented on the pull request:

    https://github.com/apache/stratos/pull/292#issuecomment-101907050
  
    @lafernando Removed the hyphens in https://github.com/apache/stratos/pull/313


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] stratos pull request: Validate application definition to have grou...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/stratos/pull/292


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] stratos pull request: Validate application definition to have grou...

Posted by Reka Thirunavukkarasu <re...@wso2.com>.
Thanks for the verification. It looks good..Will merge it..

On Thu, Apr 30, 2015 at 4:19 PM, Vishanth Balasubramaniam <
vishanthb@wso2.com> wrote:

> Hi Reka,
>
> I tested the changes with the following sample applications.
>
>    - nested-group
>    - nested-group-v2
>    - five-levels-nested-groups-app
>
> Regards,
> Vishanth
>
>
> On Thu, Apr 30, 2015 at 4:17 PM, Vishanth Balasubramaniam <
> vishanthb@wso2.com> wrote:
>
>> Hi Reka,
>>
>> Please review and merge [1].
>>
>> [1] - https://github.com/apache/stratos/pull/292
>>
>> Regards,
>> Vishanth
>>
>> On Thu, Apr 30, 2015 at 4:16 PM, Vishanth <gi...@git.apache.org> wrote:
>>
>>> GitHub user Vishanth opened a pull request:
>>>
>>>     https://github.com/apache/stratos/pull/292
>>>
>>>     Validate application definition to have group with unique aliases
>>>
>>>     This is to validate the application definition to have group with
>>> unique aliases.
>>>
>>> You can merge this pull request into a Git repository by running:
>>>
>>>     $ git pull https://github.com/Vishanth/stratos validate-alias
>>>
>>> Alternatively you can review and apply these changes as the patch at:
>>>
>>>     https://github.com/apache/stratos/pull/292.patch
>>>
>>> To close this pull request, make a commit to your master/trunk branch
>>> with (at least) the following in the commit message:
>>>
>>>     This closes #292
>>>
>>> ----
>>> commit f8f9f7190956aef6f93a44f94f8641de12263914
>>> Author: Vishanth <vi...@gmail.com>
>>> Date:   2015-04-30T10:43:52Z
>>>
>>>     Validate application definition to have group with unique aliases
>>>
>>> ----
>>>
>>>
>>> ---
>>> If your project is set up for it, you can reply to this email and have
>>> your
>>> reply appear on GitHub as well. If your project does not have this
>>> feature
>>> enabled and wishes so, or if the feature is enabled but not working,
>>> please
>>> contact infrastructure at infrastructure@apache.org or file a JIRA
>>> ticket
>>> with INFRA.
>>> ---
>>>
>>
>>
>>
>> --
>> *Vishanth Balasubramaniam*
>> Software Engineer
>> WSO2 Inc.; http://wso2.com
>> lean.enterprise.middleware
>>
>> mobile: *+94771737718*
>> about me: *http://about.me/vishanth <http://about.me/vishanth>*
>>
>>
>
>
> --
> *Vishanth Balasubramaniam*
> Software Engineer
> WSO2 Inc.; http://wso2.com
> lean.enterprise.middleware
>
> mobile: *+94771737718*
> about me: *http://about.me/vishanth <http://about.me/vishanth>*
>
>


-- 
Reka Thirunavukkarasu
Senior Software Engineer,
WSO2, Inc.:http://wso2.com,
Mobile: +94776442007

Re: [GitHub] stratos pull request: Validate application definition to have grou...

Posted by Vishanth Balasubramaniam <vi...@wso2.com>.
Hi Reka,

I tested the changes with the following sample applications.

   - nested-group
   - nested-group-v2
   - five-levels-nested-groups-app

Regards,
Vishanth


On Thu, Apr 30, 2015 at 4:17 PM, Vishanth Balasubramaniam <
vishanthb@wso2.com> wrote:

> Hi Reka,
>
> Please review and merge [1].
>
> [1] - https://github.com/apache/stratos/pull/292
>
> Regards,
> Vishanth
>
> On Thu, Apr 30, 2015 at 4:16 PM, Vishanth <gi...@git.apache.org> wrote:
>
>> GitHub user Vishanth opened a pull request:
>>
>>     https://github.com/apache/stratos/pull/292
>>
>>     Validate application definition to have group with unique aliases
>>
>>     This is to validate the application definition to have group with
>> unique aliases.
>>
>> You can merge this pull request into a Git repository by running:
>>
>>     $ git pull https://github.com/Vishanth/stratos validate-alias
>>
>> Alternatively you can review and apply these changes as the patch at:
>>
>>     https://github.com/apache/stratos/pull/292.patch
>>
>> To close this pull request, make a commit to your master/trunk branch
>> with (at least) the following in the commit message:
>>
>>     This closes #292
>>
>> ----
>> commit f8f9f7190956aef6f93a44f94f8641de12263914
>> Author: Vishanth <vi...@gmail.com>
>> Date:   2015-04-30T10:43:52Z
>>
>>     Validate application definition to have group with unique aliases
>>
>> ----
>>
>>
>> ---
>> If your project is set up for it, you can reply to this email and have
>> your
>> reply appear on GitHub as well. If your project does not have this feature
>> enabled and wishes so, or if the feature is enabled but not working,
>> please
>> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
>> with INFRA.
>> ---
>>
>
>
>
> --
> *Vishanth Balasubramaniam*
> Software Engineer
> WSO2 Inc.; http://wso2.com
> lean.enterprise.middleware
>
> mobile: *+94771737718*
> about me: *http://about.me/vishanth <http://about.me/vishanth>*
>
>


-- 
*Vishanth Balasubramaniam*
Software Engineer
WSO2 Inc.; http://wso2.com
lean.enterprise.middleware

mobile: *+94771737718*
about me: *http://about.me/vishanth <http://about.me/vishanth>*

Re: [GitHub] stratos pull request: Validate application definition to have grou...

Posted by Vishanth Balasubramaniam <vi...@wso2.com>.
Hi Reka,

Please review and merge [1].

[1] - https://github.com/apache/stratos/pull/292

Regards,
Vishanth

On Thu, Apr 30, 2015 at 4:16 PM, Vishanth <gi...@git.apache.org> wrote:

> GitHub user Vishanth opened a pull request:
>
>     https://github.com/apache/stratos/pull/292
>
>     Validate application definition to have group with unique aliases
>
>     This is to validate the application definition to have group with
> unique aliases.
>
> You can merge this pull request into a Git repository by running:
>
>     $ git pull https://github.com/Vishanth/stratos validate-alias
>
> Alternatively you can review and apply these changes as the patch at:
>
>     https://github.com/apache/stratos/pull/292.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
>     This closes #292
>
> ----
> commit f8f9f7190956aef6f93a44f94f8641de12263914
> Author: Vishanth <vi...@gmail.com>
> Date:   2015-04-30T10:43:52Z
>
>     Validate application definition to have group with unique aliases
>
> ----
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>



-- 
*Vishanth Balasubramaniam*
Software Engineer
WSO2 Inc.; http://wso2.com
lean.enterprise.middleware

mobile: *+94771737718*
about me: *http://about.me/vishanth <http://about.me/vishanth>*