You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by garrensmith <gi...@git.apache.org> on 2014/09/01 16:44:55 UTC
[GitHub] couchdb-fauxton pull request: New Documents header
GitHub user garrensmith opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/51
New Documents header
This is the start of the new documents header. Initial work by
<de...@gmail.com> and Jenn Schiffer <je...@pancaketheorem.com>.
Screenshot:
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/garrensmith/couchdb-fauxton documents-view
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/51.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #51
----
commit 11cff26fcad635b52290f73e9f29cdac7473a5b3
Author: Garren Smith <ga...@gmail.com>
Date: 2014-08-28T09:17:47Z
New Documents header
This is the start of the new documents header. Initial work by
<de...@gmail.com> and Jenn Schiffer <je...@pancaketheorem.com>.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: New Documents header
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/51#issuecomment-54141865
@kxepal thanks for reviewing this. I've fixed the bug with the sidebar disappearing and I've aligned the buttons a little better.
> But Permission / Compaction operation should be hidden in database submenu, while more common operation (new doc/view) should be available in single click.
That is a good point, it wasn't introduced in this PR. Could you create a ticket and we can think about this going forward.
>this patch introduces multiple ways how new docs/view could be created which is bad.
I don't agree 100% that it is bad. Could you create a ticket for this so we can discuss this further and not
block some of the other work on this. I would like to get this as a seperate issue so that @seanbarclay and @bradnoble can weigh in on this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: New Documents header
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/51#issuecomment-54067852
Looks awesome and exactly how it have to be. But Permission / Compaction operation should be hidden in database submenu, while more common operation (new doc/view) should be available in single click. Also, this patch introduces multiple ways how new docs/view could be created which is bad.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: New Documents header
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/51#issuecomment-54068300
Update: no need to navigate to compaction page, just jump between changes feed and all docs view. One requirement: don't wait when changes page will get completely loaded.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: New Documents header
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/51#issuecomment-54145877
No problem, I’ve fixed it.
On 02 Sep 2014, at 2:46 PM, Alexander Shorin <no...@github.com> wrote:
> @garrensmith arrr! sorry me, it should be 330 as like as sidebar has - I measured on eye, but forgot to check the values or use the ruler. So just:
>
> width: @sidebarWidth;
> And they'll match completely.
>
> —
> Reply to this email directly or view it on GitHub.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: New Documents header
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/51#issuecomment-54145728
@garrensmith arrr! sorry me, it should be 330 as like as sidebar has - I measured on eye, but forgot to check the values or use the ruler. So just:
```
width: @sidebarWidth;
```
And they'll match completely.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: New Documents header
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/51#issuecomment-54146131
haha, no problem. No one likes an off by 1 error.
On 02 Sep 2014, at 2:48 PM, Alexander Shorin <no...@github.com> wrote:
> Thanks a lot! You save me from the bad dreams because of one pixel mismatch (%
>
> —
> Reply to this email directly or view it on GitHub.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: New Documents header
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/51#issuecomment-54145032
@kxepal good spot on the side bar alignment. I've fixed it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: New Documents header
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/51#issuecomment-54146012
Thanks a lot! You save me from the bad dreams because of one pixel mismatch (%
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: New Documents header
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/51#issuecomment-54143153
@garrensmith
Confirm the fix with disappearing, but I feel I found another one(: However, it's not related to this PR and could be handled separately.
Icons align done well, but the right border of submenu button still doesn't matches sidebar`s one. This could be fixed by setting `#breadcrumbs` width as 329 instead of 326.
Agree on else: will create related issues.
P.S. patch needs in rebase:
```
error: patch failed: app/addons/documents/tests/routeSpec.js:19
error: app/addons/documents/tests/routeSpec.js: patch does not apply
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: New Documents header
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/51#issuecomment-54069500
Align of icon and borderline for new database header doesn't matches sidebar ones:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: New Documents header
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/51#issuecomment-54147007
Thanks for the reviewing. I've merged this in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: New Documents header
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/51
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: New Documents header
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/51#issuecomment-54068094
Bug: database name and his menu may eventually disappear:
to reproduce: navigate to changes feed, then back to compaction, then back to changes feed, then back to all docs, back to changes feed, back, again, repeat...profit!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---