You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2024/01/28 13:04:25 UTC

[I] Pekko 1.1 snapshots break Pekko Connectors tests [incubator-pekko]

pjfanning opened a new issue, #1066:
URL: https://github.com/apache/incubator-pekko/issues/1066

   https://github.com/apache/incubator-pekko-connectors/pull/412
   
   Needs investigation before we can release 1.1.0-M1
   
   We are getting NoSuchMethodErrors on some of the pekko utils classes like OptionConverter and FutureConverter.
   
   It could be that we need to rewrite our pekko-connector test builds - to compile with pekko 1.0 but then to test with pekko 1.1.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [I] Pekko 1.1 snapshots break Pekko Connectors tests [incubator-pekko]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on issue #1066:
URL: https://github.com/apache/incubator-pekko/issues/1066#issuecomment-1914528864

   And as a  frontier,  you always hit something, who is using scala3 ' inline for some large cross projects like this?AFAIK, no one and you are the first one. So @mdedetrich Still excellent job
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [I] Pekko 1.1 snapshots break Pekko Connectors tests [incubator-pekko]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #1066:
URL: https://github.com/apache/incubator-pekko/issues/1066#issuecomment-1914366916

   @mdedetrich see https://github.com/apache/incubator-pekko/issues/1066#issuecomment-1914347348 (TLDR - I have tested this)
   
   The main issues are with 
   ```
   org.apache.pekko.util.FutureConverters$FutureOps$
   ```
   
   Could we just undo the changes that caused this set of bin incompatibilities.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [I] Pekko 1.1 snapshots break Pekko Connectors tests [incubator-pekko]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #1066:
URL: https://github.com/apache/incubator-pekko/issues/1066#issuecomment-1914358506

   For me, the issue bolis down to https://github.com/apache/incubator-pekko/tree/main/actor/src/main/mima-filters/1.1.0.backwards.excludes
   
   We've made a very big set of binary incompatible changes in the pekko util code. The very methods that are causing this issue are listed in the binary exceptions in these exclude files.
   
   I don't want us to be forced into releasing a whole set 1.1 releases for all our repos after we do a pekko (core) 1.1 release.
   
   Can we undo the changes that led to these binary incompatibilities? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [I] Pekko 1.1 snapshots break Pekko Connectors tests [incubator-pekko]

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich closed issue #1066: Pekko 1.1 snapshots break Pekko Connectors tests
URL: https://github.com/apache/incubator-pekko/issues/1066


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [I] Pekko 1.1 snapshots break Pekko Connectors tests [incubator-pekko]

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #1066:
URL: https://github.com/apache/incubator-pekko/issues/1066#issuecomment-1914479850

   I triggered a snapshot deploy


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [I] Pekko 1.1 snapshots break Pekko Connectors tests [incubator-pekko]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #1066:
URL: https://github.com/apache/incubator-pekko/issues/1066#issuecomment-1914347348

   I forced new jar publishes of pekko and pekko-http (1.1.x) and am still getting the same issues in pekko-connectors testing
   
   https://github.com/apache/incubator-pekko-connectors/actions/runs/7694171655/job/20964422587


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [I] Pekko 1.1 snapshots break Pekko Connectors tests [incubator-pekko]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on issue #1066:
URL: https://github.com/apache/incubator-pekko/issues/1066#issuecomment-1913590493

   May because of the inline?@mdedetrich 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [I] Pekko 1.1 snapshots break Pekko Connectors tests [incubator-pekko]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on issue #1066:
URL: https://github.com/apache/incubator-pekko/issues/1066#issuecomment-1914524795

   It's scala3' inline problem and can't generate bytes code for Java usages,  it's a Scala 3's problem. 
   
   Let's defer this in pekko 2.0, when we will have a good start.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [I] Pekko 1.1 snapshots break Pekko Connectors tests [incubator-pekko]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #1066:
URL: https://github.com/apache/incubator-pekko/issues/1066#issuecomment-1914238444

   The issue is still happening. Please do not close this issue until we have proof that is fixed.
   
   https://github.com/apache/incubator-pekko-connectors/actions/runs/7686045276/job/20961266768


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [I] Pekko 1.1 snapshots break Pekko Connectors tests [incubator-pekko]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on issue #1066:
URL: https://github.com/apache/incubator-pekko/issues/1066#issuecomment-1914577275

   Seems it's ok now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [I] Pekko 1.1 snapshots break Pekko Connectors tests [incubator-pekko]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #1066:
URL: https://github.com/apache/incubator-pekko/issues/1066#issuecomment-1914492976

   No back port unless it is with new functions. Existing functions cannot be changed due to binary compatibility reasons.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [I] Pekko 1.1 snapshots break Pekko Connectors tests [incubator-pekko]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on issue #1066:
URL: https://github.com/apache/incubator-pekko/issues/1066#issuecomment-1914605109

   It's an already known issue, I think we can close this issue now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [I] Pekko 1.1 snapshots break Pekko Connectors tests [incubator-pekko]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on issue #1066:
URL: https://github.com/apache/incubator-pekko/issues/1066#issuecomment-1914520551

   I mean use pekko 1.0.0 with newer connectors 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [I] Pekko 1.1 snapshots break Pekko Connectors tests [incubator-pekko]

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #1066:
URL: https://github.com/apache/incubator-pekko/issues/1066#issuecomment-1914245519

   > The issue is still happening. Please do not close this issue until we have proof that is fixed.
   
   I didn't intend to close the issue, it auto closed when PR that referenced the issue was merged.
   
   I guess GitHub added "references" as ons of the keywords that causes linked issues to close when PR does, will have to find another word.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [I] Pekko 1.1 snapshots break Pekko Connectors tests [incubator-pekko]

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #1066:
URL: https://github.com/apache/incubator-pekko/issues/1066#issuecomment-1914245542

   > The issue is still happening. Please do not close this issue until we have proof that is fixed.
   
   I didn't intend to close the issue, it auto closed when PR that referenced the issue was merged.
   
   I guess GitHub added "references" as ons of the keywords that causes linked issues to close when PR does, will have to find another word.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [I] Pekko 1.1 snapshots break Pekko Connectors tests [incubator-pekko]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin closed issue #1066: Pekko 1.1 snapshots break Pekko Connectors tests
URL: https://github.com/apache/incubator-pekko/issues/1066


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [I] Pekko 1.1 snapshots break Pekko Connectors tests [incubator-pekko]

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #1066:
URL: https://github.com/apache/incubator-pekko/issues/1066#issuecomment-1914600409

   So only https://github.com/apache/incubator-pekko-connectors/actions/runs/7694171655/job/20969131574 has failed but it seems the cause is erroneous and may already be fixed in `main`.
   
   @pjfanning Do you want to confirm? Feel free to close the issue as completed if there are no more issues.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [I] Pekko 1.1 snapshots break Pekko Connectors tests [incubator-pekko]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on issue #1066:
URL: https://github.com/apache/incubator-pekko/issues/1066#issuecomment-1914499058

   > No back port unless it is with new functions. Existing functions cannot be changed due to binary compatibility reasons.
   
   Oh, yes, users can use it too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [I] Pekko 1.1 snapshots break Pekko Connectors tests [incubator-pekko]

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #1066:
URL: https://github.com/apache/incubator-pekko/issues/1066#issuecomment-1914364088

   > I don't want us to be forced into releasing a whole set 1.1 releases for all our repos after we do a pekko (core) 1.1 release.
   
   As you can tell we are already have an entire matrix that will reveal any such issues, ontop of this its an M1 and not a full release. Lets wait till the snapshots are published and propagated as discussed and not do anything rash


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [I] Pekko 1.1 snapshots break Pekko Connectors tests [incubator-pekko]

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #1066:
URL: https://github.com/apache/incubator-pekko/issues/1066#issuecomment-1914531465

   Re-running pekko-connectors CI now, see https://github.com/apache/incubator-pekko-connectors/actions/runs/7694171655


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [I] Pekko 1.1 snapshots break Pekko Connectors tests [incubator-pekko]

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #1066:
URL: https://github.com/apache/incubator-pekko/issues/1066#issuecomment-1914381819

   Sure, let me double check that everything compiled/propagated properly and ill set up a PR if thats the case


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [I] Pekko 1.1 snapshots break Pekko Connectors tests [incubator-pekko]

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #1066:
URL: https://github.com/apache/incubator-pekko/issues/1066#issuecomment-1914389851

   Okay the `@targetName` indeed doesn't work as expected, will remove the `inline def`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [I] Pekko 1.1 snapshots break Pekko Connectors tests [incubator-pekko]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on issue #1066:
URL: https://github.com/apache/incubator-pekko/issues/1066#issuecomment-1914484157

   Maybe we can backport this to 1.0.x one day, then it will works


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [I] Pekko 1.1 snapshots break Pekko Connectors tests [incubator-pekko]

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #1066:
URL: https://github.com/apache/incubator-pekko/issues/1066#issuecomment-1914501514

   > Oh, yes, users can use it too.
   
   They shouldn't be, this is private API
   
   But yes if we create new functions we can then propagate those functions to all of the pekko projects but tbh I am not inclined to do this, we have bigger problems and I have spent enough time (as well as others) on this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org