[GitHub] [spark] cloud-fan commented on a change in pull request #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #27017: [SPARK-30359][CORE] Do not clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset 
URL: https://github.com/apache/spark/pull/27017#discussion_r361592575
 
 

 ##########
 File path: core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala
 ##########
 @@ -1894,4 +1903,60 @@ class TaskSetManagerSuite extends SparkFunSuite with LocalSparkContext with Logg
     manager.handleFailedTask(offerResult.get.taskId, TaskState.FAILED, reason)
     assert(sched.taskSetsFailed.contains(taskSet.id))
   }
+
+  test("SPARK-30359: Don't clear executorsPendingToRemove in CoarseGrainedSchedulerBackend.reset")
 
 Review comment:
   nit: `don't clean executorsPendingToRemove at the beginning of 'reset'`. We do clear it at the end.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org