You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/10/07 17:12:04 UTC

[GitHub] [netbeans] lkishalmi opened a new pull request #2426: [NETBEANS-2644] Gradle buildSrc projects are recognized and displayed in the Build Scripts node

lkishalmi opened a new pull request #2426:
URL: https://github.com/apache/netbeans/pull/2426


   It looks like something like this:
   ![image](https://user-images.githubusercontent.com/1381701/95364290-82057380-0885-11eb-826d-3828fb3485fd.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] lkishalmi edited a comment on pull request #2426: [NETBEANS-2644] Gradle buildSrc projects are recognized and displayed in the Build Scripts node

Posted by GitBox <gi...@apache.org>.
lkishalmi edited a comment on pull request #2426:
URL: https://github.com/apache/netbeans/pull/2426#issuecomment-705616251


   @hectorespert That's valid as actually this one makes some test fail.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] lkishalmi commented on a change in pull request #2426: [NETBEANS-2644] Gradle buildSrc projects are recognized and displayed in the Build Scripts node

Posted by GitBox <gi...@apache.org>.
lkishalmi commented on a change in pull request #2426:
URL: https://github.com/apache/netbeans/pull/2426#discussion_r501927078



##########
File path: .travis.yml
##########
@@ -335,6 +335,7 @@ matrix:
             - ant $OPTS build
           script:
             - ant $OPTS -f extide/o.apache.tools.ant.module test
+            - ant $OPTS -f extide/gradle test

Review comment:
       Well I finally I had to remove this one, as it seems we have a circular cluster dependency on tests, so it fails. I need to fix that in a different PR. But definitely thanks for pointing this out!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] lkishalmi merged pull request #2426: [NETBEANS-2644] Gradle buildSrc projects are recognized and displayed in the Build Scripts node

Posted by GitBox <gi...@apache.org>.
lkishalmi merged pull request #2426:
URL: https://github.com/apache/netbeans/pull/2426


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] hectorespert commented on a change in pull request #2426: [NETBEANS-2644] Gradle buildSrc projects are recognized and displayed in the Build Scripts node

Posted by GitBox <gi...@apache.org>.
hectorespert commented on a change in pull request #2426:
URL: https://github.com/apache/netbeans/pull/2426#discussion_r501785171



##########
File path: .travis.yml
##########
@@ -335,6 +335,7 @@ matrix:
             - ant $OPTS build
           script:
             - ant $OPTS -f extide/o.apache.tools.ant.module test
+            - ant $OPTS -f extide/gradle test

Review comment:
       👍 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] lkishalmi commented on pull request #2426: [NETBEANS-2644] Gradle buildSrc projects are recognized and displayed in the Build Scripts node

Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #2426:
URL: https://github.com/apache/netbeans/pull/2426#issuecomment-705616251


   @hectorespert That's valid as actually this one makes some test fails.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] lkishalmi commented on pull request #2426: [NETBEANS-2644] Gradle buildSrc projects are recognized and displayed in the Build Scripts node

Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #2426:
URL: https://github.com/apache/netbeans/pull/2426#issuecomment-705616251


   @hectorespert That's valid as actually this one makes some test fails.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] hectorespert commented on pull request #2426: [NETBEANS-2644] Gradle buildSrc projects are recognized and displayed in the Build Scripts node

Posted by GitBox <gi...@apache.org>.
hectorespert commented on pull request #2426:
URL: https://github.com/apache/netbeans/pull/2426#issuecomment-705373049


   It would be good to add the `extide/gradle` module in Travis config to allow Travis run the tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] lkishalmi commented on a change in pull request #2426: [NETBEANS-2644] Gradle buildSrc projects are recognized and displayed in the Build Scripts node

Posted by GitBox <gi...@apache.org>.
lkishalmi commented on a change in pull request #2426:
URL: https://github.com/apache/netbeans/pull/2426#discussion_r501927078



##########
File path: .travis.yml
##########
@@ -335,6 +335,7 @@ matrix:
             - ant $OPTS build
           script:
             - ant $OPTS -f extide/o.apache.tools.ant.module test
+            - ant $OPTS -f extide/gradle test

Review comment:
       Well I finally I had to remove this one, as it seems we have a circular cluster dependency on tests, so it fails. I need to fix that in a different PR. But definitely thanks for pointing this out!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] lkishalmi merged pull request #2426: [NETBEANS-2644] Gradle buildSrc projects are recognized and displayed in the Build Scripts node

Posted by GitBox <gi...@apache.org>.
lkishalmi merged pull request #2426:
URL: https://github.com/apache/netbeans/pull/2426


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] hectorespert commented on pull request #2426: [NETBEANS-2644] Gradle buildSrc projects are recognized and displayed in the Build Scripts node

Posted by GitBox <gi...@apache.org>.
hectorespert commented on pull request #2426:
URL: https://github.com/apache/netbeans/pull/2426#issuecomment-705373049


   It would be good to add the `extide/gradle` module in Travis config to allow Travis run the tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] hectorespert commented on a change in pull request #2426: [NETBEANS-2644] Gradle buildSrc projects are recognized and displayed in the Build Scripts node

Posted by GitBox <gi...@apache.org>.
hectorespert commented on a change in pull request #2426:
URL: https://github.com/apache/netbeans/pull/2426#discussion_r501785171



##########
File path: .travis.yml
##########
@@ -335,6 +335,7 @@ matrix:
             - ant $OPTS build
           script:
             - ant $OPTS -f extide/o.apache.tools.ant.module test
+            - ant $OPTS -f extide/gradle test

Review comment:
       👍 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] lkishalmi edited a comment on pull request #2426: [NETBEANS-2644] Gradle buildSrc projects are recognized and displayed in the Build Scripts node

Posted by GitBox <gi...@apache.org>.
lkishalmi edited a comment on pull request #2426:
URL: https://github.com/apache/netbeans/pull/2426#issuecomment-705616251


   @hectorespert That's valid as actually this one makes some test fail.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists