You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by st...@apache.org on 2020/07/20 09:54:33 UTC
[hadoop] branch branch-3.3 updated (187b161 -> 5aa9396)
This is an automated email from the ASF dual-hosted git repository.
stevel pushed a change to branch branch-3.3
in repository https://gitbox.apache.org/repos/asf/hadoop.git.
from 187b161 HADOOP-17130. Configuration.getValByRegex() shouldn't be updating the results while fetching. (#2142)
new e018521 HADOOP-16682. ABFS: Removing unnecessary toString() invocations
new 5aa9396 HADOOP-17107. hadoop-azure parallel tests not working on recent JDKs (#2118)
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
hadoop-tools/hadoop-azure/pom.xml | 81 ++++------------------
.../hadoop/fs/azurebfs/AzureBlobFileSystem.java | 8 +--
.../fs/azurebfs/AzureBlobFileSystemStore.java | 22 +++---
3 files changed, 27 insertions(+), 84 deletions(-)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org
[hadoop] 01/02: HADOOP-16682. ABFS: Removing unnecessary toString()
invocations
Posted by st...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
stevel pushed a commit to branch branch-3.3
in repository https://gitbox.apache.org/repos/asf/hadoop.git
commit e01852181a17552d6f0d33b7aa17ce98f984888b
Author: bilaharith <52...@users.noreply.github.com>
AuthorDate: Sat Jul 18 22:30:18 2020 +0530
HADOOP-16682. ABFS: Removing unnecessary toString() invocations
- Contributed by Bilahari T H
Change-Id: Id55495b44d81533d1d3654de2553c709f505f7eb
---
.../hadoop/fs/azurebfs/AzureBlobFileSystem.java | 8 ++++----
.../fs/azurebfs/AzureBlobFileSystemStore.java | 22 +++++++++++-----------
2 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystem.java b/hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystem.java
index 6694c13..8fce0ff 100644
--- a/hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystem.java
+++ b/hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystem.java
@@ -271,9 +271,9 @@ public class AzureBlobFileSystem extends FileSystem {
}
public boolean rename(final Path src, final Path dst) throws IOException {
- LOG.debug(
- "AzureBlobFileSystem.rename src: {} dst: {}", src.toString(), dst.toString());
+ LOG.debug("AzureBlobFileSystem.rename src: {} dst: {}", src, dst);
statIncrement(CALL_RENAME);
+
trailingPeriodCheck(dst);
Path parentFolder = src.getParent();
@@ -777,7 +777,7 @@ public class AzureBlobFileSystem extends FileSystem {
@Override
public void modifyAclEntries(final Path path, final List<AclEntry> aclSpec)
throws IOException {
- LOG.debug("AzureBlobFileSystem.modifyAclEntries path: {}", path.toString());
+ LOG.debug("AzureBlobFileSystem.modifyAclEntries path: {}", path);
if (!getIsNamespaceEnabled()) {
throw new UnsupportedOperationException(
@@ -926,7 +926,7 @@ public class AzureBlobFileSystem extends FileSystem {
*/
@Override
public AclStatus getAclStatus(final Path path) throws IOException {
- LOG.debug("AzureBlobFileSystem.getAclStatus path: {}", path.toString());
+ LOG.debug("AzureBlobFileSystem.getAclStatus path: {}", path);
if (!getIsNamespaceEnabled()) {
throw new UnsupportedOperationException(
diff --git a/hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java b/hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java
index 8e0e6c1..1ed4683 100644
--- a/hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java
+++ b/hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java
@@ -413,8 +413,8 @@ public class AzureBlobFileSystemStore implements Closeable {
client.getFileSystem(),
path,
overwrite,
- permission.toString(),
- umask.toString(),
+ permission,
+ umask,
isNamespaceEnabled);
String relativePath = getRelativePath(path);
@@ -850,7 +850,7 @@ public class AzureBlobFileSystemStore implements Closeable {
LOG.debug(
"setOwner filesystem: {} path: {} owner: {} group: {}",
client.getFileSystem(),
- path.toString(),
+ path,
owner,
group);
@@ -877,8 +877,8 @@ public class AzureBlobFileSystemStore implements Closeable {
LOG.debug(
"setPermission filesystem: {} path: {} permission: {}",
client.getFileSystem(),
- path.toString(),
- permission.toString());
+ path,
+ permission);
final AbfsRestOperation op = client.setPermission(getRelativePath(path),
String.format(AbfsHttpConstants.PERMISSION_FORMAT, permission.toOctal()));
@@ -899,7 +899,7 @@ public class AzureBlobFileSystemStore implements Closeable {
LOG.debug(
"modifyAclEntries filesystem: {} path: {} aclSpec: {}",
client.getFileSystem(),
- path.toString(),
+ path,
AclEntry.aclSpecToString(aclSpec));
identityTransformer.transformAclEntriesForSetRequest(aclSpec);
@@ -940,7 +940,7 @@ public class AzureBlobFileSystemStore implements Closeable {
LOG.debug(
"removeAclEntries filesystem: {} path: {} aclSpec: {}",
client.getFileSystem(),
- path.toString(),
+ path,
AclEntry.aclSpecToString(aclSpec));
identityTransformer.transformAclEntriesForSetRequest(aclSpec);
@@ -981,7 +981,7 @@ public class AzureBlobFileSystemStore implements Closeable {
LOG.debug(
"removeDefaultAcl filesystem: {} path: {}",
client.getFileSystem(),
- path.toString());
+ path);
String relativePath = getRelativePath(path);
@@ -1023,7 +1023,7 @@ public class AzureBlobFileSystemStore implements Closeable {
LOG.debug(
"removeAcl filesystem: {} path: {}",
client.getFileSystem(),
- path.toString());
+ path);
String relativePath = getRelativePath(path);
@@ -1062,7 +1062,7 @@ public class AzureBlobFileSystemStore implements Closeable {
LOG.debug(
"setAcl filesystem: {} path: {} aclspec: {}",
client.getFileSystem(),
- path.toString(),
+ path,
AclEntry.aclSpecToString(aclSpec));
identityTransformer.transformAclEntriesForSetRequest(aclSpec);
@@ -1103,7 +1103,7 @@ public class AzureBlobFileSystemStore implements Closeable {
LOG.debug(
"getAclStatus filesystem: {} path: {}",
client.getFileSystem(),
- path.toString());
+ path);
AbfsRestOperation op = client.getAclStatus(getRelativePath(path));
AbfsHttpOperation result = op.getResult();
---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org
[hadoop] 02/02: HADOOP-17107. hadoop-azure parallel tests not
working on recent JDKs (#2118)
Posted by st...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
stevel pushed a commit to branch branch-3.3
in repository https://gitbox.apache.org/repos/asf/hadoop.git
commit 5aa9396a58679ad5837670f21b9841713f23c4c0
Author: Steve Loughran <st...@cloudera.com>
AuthorDate: Mon Jul 20 10:51:26 2020 +0100
HADOOP-17107. hadoop-azure parallel tests not working on recent JDKs (#2118)
Contributed by Steve Loughran.
Change-Id: I972264aed36f384b7ae23e214326ef7870261cf5
---
hadoop-tools/hadoop-azure/pom.xml | 81 ++++++---------------------------------
1 file changed, 12 insertions(+), 69 deletions(-)
diff --git a/hadoop-tools/hadoop-azure/pom.xml b/hadoop-tools/hadoop-azure/pom.xml
index 7c45488..6d9b737 100644
--- a/hadoop-tools/hadoop-azure/pom.xml
+++ b/hadoop-tools/hadoop-azure/pom.xml
@@ -303,31 +303,13 @@
<build>
<plugins>
<plugin>
- <artifactId>maven-antrun-plugin</artifactId>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-maven-plugins</artifactId>
<executions>
<execution>
- <id>create-parallel-tests-dirs</id>
- <phase>test-compile</phase>
- <configuration>
- <target>
- <script language="javascript"><![CDATA[
- var baseDirs = [
- project.getProperty("test.build.data"),
- project.getProperty("test.build.dir"),
- project.getProperty("hadoop.tmp.dir")
- ];
- for (var i in baseDirs) {
- for (var j = 1; j <= ${testsThreadCount}; ++j) {
- var mkdir = project.createTask("mkdir");
- mkdir.setDir(new java.io.File(baseDirs[i], j));
- mkdir.perform();
- }
- }
- ]]></script>
- </target>
- </configuration>
+ <id>parallel-tests-createdir</id>
<goals>
- <goal>run</goal>
+ <goal>parallel-tests-createdir</goal>
</goals>
</execution>
</executions>
@@ -342,7 +324,6 @@
<goal>test</goal>
</goals>
<configuration>
- <forkCount>1</forkCount>
<forkCount>${testsThreadCount}</forkCount>
<reuseForks>false</reuseForks>
<argLine>${maven-surefire-plugin.argLine} -DminiClusterDedicatedDirs=true</argLine>
@@ -408,7 +389,6 @@
<goal>verify</goal>
</goals>
<configuration>
- <forkCount>1</forkCount>
<forkCount>${testsThreadCount}</forkCount>
<reuseForks>false</reuseForks>
<argLine>${maven-surefire-plugin.argLine} -DminiClusterDedicatedDirs=true</argLine>
@@ -486,31 +466,13 @@
<build>
<plugins>
<plugin>
- <artifactId>maven-antrun-plugin</artifactId>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-maven-plugins</artifactId>
<executions>
<execution>
- <id>create-parallel-tests-dirs</id>
- <phase>test-compile</phase>
- <configuration>
- <target>
- <script language="javascript"><![CDATA[
- var baseDirs = [
- project.getProperty("test.build.data"),
- project.getProperty("test.build.dir"),
- project.getProperty("hadoop.tmp.dir")
- ];
- for (var i in baseDirs) {
- for (var j = 1; j <= ${testsThreadCount}; ++j) {
- var mkdir = project.createTask("mkdir");
- mkdir.setDir(new java.io.File(baseDirs[i], j));
- mkdir.perform();
- }
- }
- ]]></script>
- </target>
- </configuration>
+ <id>parallel-tests-createdir</id>
<goals>
- <goal>run</goal>
+ <goal>parallel-tests-createdir</goal>
</goals>
</execution>
</executions>
@@ -652,31 +614,13 @@
<build>
<plugins>
<plugin>
- <artifactId>maven-antrun-plugin</artifactId>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-maven-plugins</artifactId>
<executions>
<execution>
- <id>create-parallel-tests-dirs</id>
- <phase>test-compile</phase>
- <configuration>
- <target>
- <script language="javascript"><![CDATA[
- var baseDirs = [
- project.getProperty("test.build.data"),
- project.getProperty("test.build.dir"),
- project.getProperty("hadoop.tmp.dir")
- ];
- for (var i in baseDirs) {
- for (var j = 1; j <= ${testsThreadCount}; ++j) {
- var mkdir = project.createTask("mkdir");
- mkdir.setDir(new java.io.File(baseDirs[i], j));
- mkdir.perform();
- }
- }
- ]]></script>
- </target>
- </configuration>
+ <id>parallel-tests-createdir</id>
<goals>
- <goal>run</goal>
+ <goal>parallel-tests-createdir</goal>
</goals>
</execution>
</executions>
@@ -691,7 +635,6 @@
<goal>test</goal>
</goals>
<configuration>
- <forkCount>1</forkCount>
<forkCount>${testsThreadCount}</forkCount>
<reuseForks>false</reuseForks>
<argLine>${maven-surefire-plugin.argLine} -DminiClusterDedicatedDirs=true</argLine>
---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org