You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/16 17:34:36 UTC

[GitHub] [airflow] casassg commented on a change in pull request #10587: @dag decorator

casassg commented on a change in pull request #10587:
URL: https://github.com/apache/airflow/pull/10587#discussion_r505969872



##########
File path: airflow/models/dagparam.py
##########
@@ -0,0 +1,61 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from typing import Any, Dict, List, Union
+
+from airflow.exceptions import AirflowException
+from airflow.models.dag import DAG  # pylint: disable=R0401
+from airflow.models.xcom import XCOM_RETURN_KEY
+from inspect import signature, Parameter
+from airflow.exceptions import AirflowException
+from airflow.models.dag import DAG
+
+import functools
+
+class DagParam:
+    """
+    
+    """
+
+    def __init__(self, dag: DAG, name: str, default: Any):
+        dag.params[name] = default

Review comment:
       Tecnically all it matter is that it's on the dictionary. Not sure if it's worth adding an extra method.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org