[jira] [Commented] (ZOOKEEPER-1379) 'printwatches, redo, history and connect '. client commands always print usage. This is not necessary

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13559179#comment-13559179 ] 

Hadoop QA commented on ZOOKEEPER-1379:
--------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12565863/ZOOKEEPER-1379.2.patch
  against trunk revision 1434978.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1351//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1351//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1351//console

This message is automatically generated.
                
> 'printwatches, redo, history and connect '. client commands always print usage. This is not necessary
> -----------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1379
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1379
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: java client
>    Affects Versions: 3.4.0, 3.5.0
>            Reporter: kavita sharma
>            Assignee: Edward Ribeiro
>            Priority: Minor
>             Fix For: 3.5.0, 3.4.6
>
>         Attachments: ZOOKEEPER-1379.2.patch, ZOOKEEPER-1379.patch
>
>
> while executing the commands:
> 'printwatches, redo, history and connect usage is getting print 
> .basically we are printing usage if user has entered the command 
> wrong but in these commands case every time usage is getting print.
> eg
> {noformat}
> [zk: localhost:2181(CONNECTED) 0] printwatches
> printwatches is on
> ZooKeeper -server host:port cmd args
> 	connect host:port
> 	get path [watch]
> 	ls path [watch]
> 	set path data [version]
> 	delquota [-n|-b] path
> 	quit 
> 	printwatches on|off
> 	create [-s] [-e] path data acl
> 	stat path [watch]
> 	close 
> 	ls2 path [watch]
> 	history 
> 	listquota path
> 	setAcl path acl
> 	getAcl path
> 	sync path
> 	redo cmdno
> 	addauth scheme auth
> 	delete path [version]
> 	setquota -n|-b val path
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira