You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Madhan Neethiraj <ma...@apache.org> on 2015/09/22 19:30:36 UTC
Review Request 38638: RANGER-274: updated DB schema for
tag-based-policy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38638/
-----------------------------------------------------------
Review request for ranger, Gautam Borad, Abhay Kulkarni, and Velmurugan Periasamy.
Bugs: RANGER-274
https://issues.apache.org/jira/browse/RANGER-274
Repository: ranger
Description
-------
Updated DB schema for tag-based-policy for the following:
- rename table x_service_resource_element_value to x_service_resource_element_val, to comply with table name length restrictions
- remove unused guid columns
- add missed UNIQUE KEY constraint to guid columns
Diffs
-----
security-admin/db/mysql/patches/016-updated-schema-for-tag-based-policy.sql 10eaf4c
security-admin/src/main/java/org/apache/ranger/biz/TagDBStore.java ca15f98
security-admin/src/main/java/org/apache/ranger/entity/XXServiceResourceElement.java a545133
security-admin/src/main/java/org/apache/ranger/entity/XXServiceResourceElementValue.java 23b17b9
security-admin/src/main/java/org/apache/ranger/entity/XXTagAttribute.java 3bb2207
security-admin/src/main/java/org/apache/ranger/entity/XXTagAttributeDef.java 4653481
security-admin/src/main/java/org/apache/ranger/service/RangerTagDefServiceBase.java 1b4aa26
Diff: https://reviews.apache.org/r/38638/diff/
Testing
-------
Verified that tag creation/retrival/delete flow is not impacted with this update.
Thanks,
Madhan Neethiraj
Re: Review Request 38638: RANGER-274: updated DB schema for
tag-based-policy
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38638/
-----------------------------------------------------------
(Updated Sept. 23, 2015, 1:12 a.m.)
Review request for ranger, Gautam Borad, Abhay Kulkarni, and Velmurugan Periasamy.
Changes
-------
- resized GUID columns to VARCHAR(64), from VARCHAR(512)
- resized NAME column in x_tag_def/x_tag_attr_def/x_tag_attr to VARCHAR(256) from VARCHAR(512)
- resized VALUE column in x_service_resource_element_val from VARCHAR(512) to VARCHAR(1024), to be consistent with x_policy_resource_map
- updated GUID generation algorithm to use JDK class UUID
Bugs: RANGER-274
https://issues.apache.org/jira/browse/RANGER-274
Repository: ranger
Description
-------
Updated DB schema for tag-based-policy for the following:
- rename table x_service_resource_element_value to x_service_resource_element_val, to comply with table name length restrictions
- remove unused guid columns
- add missed UNIQUE KEY constraint to guid columns
Diffs (updated)
-----
security-admin/db/mysql/patches/016-updated-schema-for-tag-based-policy.sql 10eaf4c
security-admin/src/main/java/org/apache/ranger/biz/TagDBStore.java ca15f98
security-admin/src/main/java/org/apache/ranger/common/GUIDUtil.java 6710088
security-admin/src/main/java/org/apache/ranger/entity/XXServiceResourceElement.java a545133
security-admin/src/main/java/org/apache/ranger/entity/XXServiceResourceElementValue.java 23b17b9
security-admin/src/main/java/org/apache/ranger/entity/XXTagAttribute.java 3bb2207
security-admin/src/main/java/org/apache/ranger/entity/XXTagAttributeDef.java 4653481
security-admin/src/main/java/org/apache/ranger/service/RangerTagDefServiceBase.java 1b4aa26
Diff: https://reviews.apache.org/r/38638/diff/
Testing
-------
Verified that tag creation/retrival/delete flow is not impacted with this update.
Thanks,
Madhan Neethiraj
Re: Review Request 38638: RANGER-274: updated DB schema for
tag-based-policy
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38638/#review100094
-----------------------------------------------------------
Ship it!
Ship It!
- Abhay Kulkarni
On Sept. 22, 2015, 5:30 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38638/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2015, 5:30 p.m.)
>
>
> Review request for ranger, Gautam Borad, Abhay Kulkarni, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-274
> https://issues.apache.org/jira/browse/RANGER-274
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Updated DB schema for tag-based-policy for the following:
> - rename table x_service_resource_element_value to x_service_resource_element_val, to comply with table name length restrictions
> - remove unused guid columns
> - add missed UNIQUE KEY constraint to guid columns
>
>
> Diffs
> -----
>
> security-admin/db/mysql/patches/016-updated-schema-for-tag-based-policy.sql 10eaf4c
> security-admin/src/main/java/org/apache/ranger/biz/TagDBStore.java ca15f98
> security-admin/src/main/java/org/apache/ranger/entity/XXServiceResourceElement.java a545133
> security-admin/src/main/java/org/apache/ranger/entity/XXServiceResourceElementValue.java 23b17b9
> security-admin/src/main/java/org/apache/ranger/entity/XXTagAttribute.java 3bb2207
> security-admin/src/main/java/org/apache/ranger/entity/XXTagAttributeDef.java 4653481
> security-admin/src/main/java/org/apache/ranger/service/RangerTagDefServiceBase.java 1b4aa26
>
> Diff: https://reviews.apache.org/r/38638/diff/
>
>
> Testing
> -------
>
> Verified that tag creation/retrival/delete flow is not impacted with this update.
>
>
> Thanks,
>
> Madhan Neethiraj
>
>