[jira] Commented: (THRIFT-492) Add Timeout Argument to thrift_client:call()

["Todd Lipcon (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707374#action_12707374 ] 

Todd Lipcon commented on THRIFT-492:
------------------------------------

Looks good to me

> Add Timeout Argument to thrift_client:call()
> --------------------------------------------
>
>                 Key: THRIFT-492
>                 URL: https://issues.apache.org/jira/browse/THRIFT-492
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Library (Erlang)
>         Environment: N/A
>            Reporter: Wil Tan
>            Priority: Minor
>         Attachments: thrift_client.diff
>
>
> thrift_client:call() does not use a timeout option when calling gen_server:call(), so the default timeout of 5 seconds is used. It would be good to offer that to the user of the module.
> The attached trivial patch does exports a new function call/4 which does this, and makes the original call/3 function pass in the default 5000 ms timeout value.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.