You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2006/09/18 18:37:13 UTC
[Bug 5102] New: FORGED_HOTMAIL_RCVD false positive
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5102
Summary: FORGED_HOTMAIL_RCVD false positive
Product: Spamassassin
Version: 3.1.5
Platform: Other
OS/Version: Linux
Status: NEW
Severity: normal
Priority: P5
Component: Rules (Eval Tests)
AssignedTo: dev@spamassassin.apache.org
ReportedBy: dot@dotat.at
The Received: header checks in _check_for_forged_hotmail_received_headers() do
not allow for legitimate email from Hotmail received by Exim (and perhaps other
MTAs).
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5102] FORGED_HOTMAIL_RCVD false positive
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5102
dot@dotat.at changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #3698|hotmail-patch |/home/fanf2/scratch/hotmail-
filename| |patch
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5102] FORGED_HOTMAIL_RCVD false positive
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5102
------- Additional Comments From dot@dotat.at 2007-05-02 08:18 -------
Fix committed to 3.2 branch
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5102] FORGED_HOTMAIL_RCVD false positive
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5102
------- Additional Comments From jm@jmason.org 2007-05-02 07:53 -------
did we miss this in 3.2.0? drat :(
might be worth backporting to 3.2.1 as well.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5102] [Review] FORGED_HOTMAIL_RCVD false positive
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5102
sidney@sidney.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|FORGED_HOTMAIL_RCVD false |[Review] FORGED_HOTMAIL_RCVD
|positive |false positive
Status Whiteboard| |needs 3 votes
------- Additional Comments From sidney@sidney.com 2007-06-04 21:42 -------
This looks ready for review and voting for 3.2.1 (This is not a vote)
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5102] [Review] FORGED_HOTMAIL_RCVD false positive
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5102
------- Additional Comments From dot@dotat.at 2007-06-05 03:05 -------
(In reply to comment #14)
> This looks like it ought to already have two votes, from Tony and Justin, but I
> can't tell exactly which patch to vote on. Tony or Justin, can you make that
> clear? Then we can get it into 3.2.1.
I intended to merge this commit from the trunk to 3.2:
http://svn.apache.org/viewvc/spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/HeaderEval.pm?
r1=495220&r2=534488
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5102] FORGED_HOTMAIL_RCVD false positive
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5102
------- Additional Comments From dot@dotat.at 2006-09-18 16:39 -------
Created an attachment (id=3697)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=3697&action=view)
Example Received: headers
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5102] FORGED_HOTMAIL_RCVD false positive
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5102
------- Additional Comments From dot@dotat.at 2007-05-02 08:11 -------
My bad - should have committed it ages ago
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5102] [Review] FORGED_HOTMAIL_RCVD false positive
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5102
sidney@sidney.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 2 votes |needs 1 vote
------- Additional Comments From sidney@sidney.com 2007-06-06 21:49 -------
+1 on the new patch without the capture
By the way I notice that it was committed to trunk already as r545055.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5102] [Review] FORGED_HOTMAIL_RCVD false positive
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5102
------- Additional Comments From sidney@sidney.com 2007-06-04 22:39 -------
This looks like it ought to already have two votes, from Tony and Justin, but I
can't tell exactly which patch to vote on. Tony or Justin, can you make that
clear? Then we can get it into 3.2.1.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5102] [Review] FORGED_HOTMAIL_RCVD false positive
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5102
------- Additional Comments From sidney@sidney.com 2007-06-06 20:51 -------
> Feel free to add a '?:' to eliminate the capture though
Put it up as a patch and I'll vote on again. That way it will be official and
have two votes ready when Justin wakes up this morning (his time) and sees it.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5102] FORGED_HOTMAIL_RCVD false positive
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5102
------- Additional Comments From a.bramley@gmail.com 2006-10-30 09:34 -------
Created an attachment (id=3738)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=3738&action=view)
proposed patch (draconian regex)
Also noticed this issue, but I created a fairly draconian regex instead. Hope
this is fixed in the next release...
--alex
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5102] [Review] FORGED_HOTMAIL_RCVD false positive
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5102
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 3 votes |needs 2 votes
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5102] [Review] FORGED_HOTMAIL_RCVD false positive
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5102
spamassassin@dostech.ca changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #3971 is|0 |1
obsolete| |
------- Additional Comments From spamassassin@dostech.ca 2007-06-06 20:56 -------
Created an attachment (id=3974)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=3974&action=view)
"that change" without the unused capture
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5102] FORGED_HOTMAIL_RCVD false positive
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5102
------- Additional Comments From dot@dotat.at 2006-09-18 17:36 -------
Created an attachment (id=3699)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=3699&action=view)
better (less picky) regex
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5102] [Review] FORGED_HOTMAIL_RCVD false positive
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5102
------- Additional Comments From dot@dotat.at 2007-06-07 01:13 -------
+1
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5102] FORGED_HOTMAIL_RCVD false positive
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5102
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|Undefined |3.2.1
------- Additional Comments From jm@jmason.org 2007-05-02 08:56 -------
setting to 3.2.1. looks like you weren't in the "EditBugs" bugzilla group --
you should be able to set milestones now...
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5102] [Review] FORGED_HOTMAIL_RCVD false positive
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5102
sidney@sidney.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
Status Whiteboard|needs 1 vote |
------- Additional Comments From sidney@sidney.com 2007-06-07 01:28 -------
Committed to 3.2 branch revision 545100.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5102] [Review] FORGED_HOTMAIL_RCVD false positive
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5102
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #3698 is|0 |1
obsolete| |
Attachment #3699 is|0 |1
obsolete| |
Attachment #3738 is|0 |1
obsolete| |
------- Additional Comments From jm@jmason.org 2007-06-06 13:54 -------
Created an attachment (id=3971)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=3971&action=view)
that change, as a patch against 3.2.0
here's the change as a patch attachment. Tony, that's the easiest way to do
patch reviews, we find, since we can then (a) test it ourselves if we feel like
it and (b) be sure that the change will still apply correctly against current
head of the branch.
my vote: +1
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5102] FORGED_HOTMAIL_RCVD false positive
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5102
dot@dotat.at changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Additional Comments From dot@dotat.at 2007-05-02 07:47 -------
Fix committed to trunk.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5102] FORGED_HOTMAIL_RCVD false positive
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5102
------- Additional Comments From dot@dotat.at 2006-09-18 16:40 -------
Created an attachment (id=3698)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=3698&action=view)
Proposed patch
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5102] [Review] FORGED_HOTMAIL_RCVD false positive
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5102
spamassassin@dostech.ca changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 1 vote |go
------- Additional Comments From spamassassin@dostech.ca 2007-06-06 20:26 -------
+ if ($rcvd =~ /from (\S*\.)?hotmail.com \(\S+\.hotmail(?:\.msn)?\.com[ \)]/ &&
$ip)
+1. Feel free to add a '?:' to eliminate the capture though.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5102] [Review] FORGED_HOTMAIL_RCVD false positive
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5102
spamassassin@dostech.ca changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|go |needs 2 votes
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5102] FORGED_HOTMAIL_RCVD false positive
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5102
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |
------- Additional Comments From jm@jmason.org 2007-05-02 08:25 -------
Tony -- hold on -- could you revert that change to 3.2?
the 3.2 branch is now in R-T-C mode (although I haven't officially announced
it yet), so we'll need to vote on the patch before it can be applied.
Just revert r534510, attach it as a diff to this bug, and set the milestone
to "3.2.1" for voting...
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5102] [Review] FORGED_HOTMAIL_RCVD false positive
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5102
sidney@sidney.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 2 votes |needs 1 vote
------- Additional Comments From sidney@sidney.com 2007-06-06 14:33 -------
+1
Tony, normally the vote of the committer submitting the fix is implicit, but in
this case Justin actually put together the patch file we are voting on so if you
want to vote for this to bring us up to the required three votes, please do so.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5102] FORGED_HOTMAIL_RCVD false positive
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5102
dot@dotat.at changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |ASSIGNED
------- Additional Comments From dot@dotat.at 2007-05-02 09:03 -------
Looks good from here. Thanks for your help.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5102] FORGED_HOTMAIL_RCVD false positive
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5102
------- Additional Comments From dot@dotat.at 2007-05-02 08:34 -------
Reopen for 3.2.1 review
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.