[GitHub] [calcite] fib-seq opened a new pull request #1528: [CALCITE-3436] CalciteConnectionConfigImpl.set obliterates previous property values

[GitBox <gi...@apache.org>]

fib-seq opened a new pull request #1528: [CALCITE-3436] CalciteConnectionConfigImpl.set obliterates previous property values
URL: https://github.com/apache/calcite/pull/1528
 
 
   Resolved issue where if context was passed a CalciteConnectionConfig, it would not set the default CalciteConnectionConfig settings.
   
   I introduced a few tests that checks for if the values will get obliterated upon calling CalciteConnectionConfigImpl.set(). Upon further inspection, when creating a new Properties object with properties argument, these will be stored in a defaults field. To return a copy of the config without having it set in the defaults field I cloned the properties field instead. 
   
   Lastly, refactored the `frameworkConfig.getCostFactory()` method into the field `costFactory`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services