[GitHub] [phoenix] gourabtaparia commented on a diff in pull request #1546: PHOENIX-6052 Include syscat time in mutation time

[GitBox <gi...@apache.org>]

gourabtaparia commented on code in PR #1546:
URL: https://github.com/apache/phoenix/pull/1546#discussion_r1064807671


##########
phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java:
##########
@@ -1198,6 +1199,7 @@ private void sendBatch(Map<TableRef, MultiRowMutationState> commitBatch, long[]
         Map<TableInfo, List<Mutation>> physicalTableMutationMap = Maps.newLinkedHashMap();
 
         // add tracing for this operation
+        long startTime = EnvironmentEdgeManager.currentTimeMillis();

Review Comment:
   nitpick : the above L 1201 "add tracing" comment was for line L 1203 - maybe we can add your change just above that comment - to make the comment and code nearby as last time.



##########
phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java:
##########
@@ -1411,8 +1415,8 @@ public List<Mutation> getMutationList() {
                     child.stop();
                     child.stop();
                     shouldRetry = false;
-                    mutationCommitTime = EnvironmentEdgeManager.currentTimeMillis() - startTime;
-                    GLOBAL_MUTATION_COMMIT_TIME.update(mutationCommitTime);
+//                    mutationCommitTime = EnvironmentEdgeManager.currentTimeMillis() - startTime;

Review Comment:
   Why this code commented ?  Please fix this



##########
phoenix-core/src/main/java/org/apache/phoenix/monitoring/MetricType.java:
##########
@@ -208,23 +209,23 @@ private MetricType(String shortName, String description, LogLevel logLevel, PDat
     public String description() {
         return description;
     }
-    

Review Comment:
   nitpick : there are various changes fixing the extra spaces not part of the change - should we skip this as part of this change ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org