You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2018/10/21 10:54:41 UTC

[GitHub] Georift opened a new pull request #1146: Add grouping to databases with IDs containing '/'

Georift opened a new pull request #1146: Add grouping to databases with IDs containing '/'
URL: https://github.com/apache/couchdb-fauxton/pull/1146
 
 
   ## Overview
   
   Attempt at grouping database that share the same 'prefix/' as described in #869. I don't think this is quite done I have a few more ideas but I would appreciate some feedback before I go much further.
   
   Some points:
    - Should `prefix/again/db` be contained within `prefix/`'s fold? Right now all folds exist at the top level like so: _(also notice that databases with only one of that prefix are not folded)_
   ![folding-single-level](https://user-images.githubusercontent.com/859430/47265902-a9ac8580-d561-11e8-92e0-bba840a89f4a.png)
   - There is quite a bit of space in the prefix name row. I was thinking we could put a count of folded database.
    - At the moment it defaults to all folded. Would it be worth adding a default fold all on and off user preference?
    - I made use of ramda as I'm comfortable working with it. I noticed afterwards lodash already exists. If you would prefer I can convert my code to that.
   
   ## GitHub issue number
   
   Fixes #869
   
   ## Checklist
   
   - [X] Code is written and works correctly;
   - [ ] Changes are covered by tests;
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services