Re: [PR] Enables Nodeport Support For the Proxy Service [pulsar-helm-chart]

["lhotari (via GitHub)" <gi...@apache.org>]

lhotari commented on code in PR #376:
URL: https://github.com/apache/pulsar-helm-chart/pull/376#discussion_r1422317113


##########
charts/pulsar/templates/proxy-service.yaml:
##########
@@ -38,20 +38,40 @@ spec:
       port: {{ .Values.proxy.ports.http }}
       protocol: TCP
       targetPort: sts-http
+      {{- if and (eq .Values.service.type "NodePort") (ne .Values.service.nodePorts.http "") }}
+        nodePort: {{ .Values.service.nodePorts.http }}

Review Comment:
   please check the indentation



##########
charts/pulsar/templates/proxy-service.yaml:
##########
@@ -38,20 +38,40 @@ spec:
       port: {{ .Values.proxy.ports.http }}
       protocol: TCP
       targetPort: sts-http
+      {{- if and (eq .Values.service.type "NodePort") (ne .Values.service.nodePorts.http "") }}
+        nodePort: {{ .Values.service.nodePorts.http }}
+      {{- else}}
+        nodePort: null

Review Comment:
   Could we simply omit setting nodePort instead of setting the value to null?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org