You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Tomasz Pik (JIRA)" <ji...@codehaus.org> on 2008/02/29 13:41:28 UTC
[jira] Created: (MENFORCER-37) 'noSnapshots' rule do not check
version of parent
'noSnapshots' rule do not check version of parent
-------------------------------------------------
Key: MENFORCER-37
URL: http://jira.codehaus.org/browse/MENFORCER-37
Project: Maven 2.x Enforcer Plugin
Issue Type: Bug
Components: Standard Rules
Affects Versions: 1.0-alpha-3
Reporter: Tomasz Pik
Assignee: Brian Fox
'noSnapshots' is passing when parent is defined to be SNAPSHOT, IMHO parent is also a dependency so it should be checked and rule should throw an error if parent is a SNAPSHOT.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MENFORCER-37) 'noSnapshots' rule do not check
version of parent
Posted by "Nick Stolwijk (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MENFORCER-37?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nick Stolwijk updated MENFORCER-37:
-----------------------------------
Attachment: RequireReleaseDeps.patch
> 'noSnapshots' rule do not check version of parent
> -------------------------------------------------
>
> Key: MENFORCER-37
> URL: http://jira.codehaus.org/browse/MENFORCER-37
> Project: Maven 2.x Enforcer Plugin
> Issue Type: Bug
> Components: Standard Rules
> Affects Versions: 1.0-alpha-3
> Reporter: Tomasz Pik
> Assignee: Brian Fox
> Fix For: 1.0
>
> Attachments: RequireReleaseDeps.patch
>
>
> 'noSnapshots' is passing when parent is defined to be SNAPSHOT, IMHO parent is also a dependency so it should be checked and rule should throw an error if parent is a SNAPSHOT.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MENFORCER-37) 'noSnapshots' rule do not check
version of parent
Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MENFORCER-37?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Fox updated MENFORCER-37:
-------------------------------
Fix Version/s: 1.0
> 'noSnapshots' rule do not check version of parent
> -------------------------------------------------
>
> Key: MENFORCER-37
> URL: http://jira.codehaus.org/browse/MENFORCER-37
> Project: Maven 2.x Enforcer Plugin
> Issue Type: Bug
> Components: Standard Rules
> Affects Versions: 1.0-alpha-3
> Reporter: Tomasz Pik
> Assignee: Brian Fox
> Fix For: 1.0
>
>
> 'noSnapshots' is passing when parent is defined to be SNAPSHOT, IMHO parent is also a dependency so it should be checked and rule should throw an error if parent is a SNAPSHOT.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MENFORCER-37) 'noSnapshots' rule do not check
version of parent
Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MENFORCER-37?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Fox closed MENFORCER-37.
------------------------------
Resolution: Fixed
Fixed. I also applied this to the requireReleaseVersion rule.
> 'noSnapshots' rule do not check version of parent
> -------------------------------------------------
>
> Key: MENFORCER-37
> URL: http://jira.codehaus.org/browse/MENFORCER-37
> Project: Maven 2.x Enforcer Plugin
> Issue Type: Bug
> Components: Standard Rules
> Affects Versions: 1.0-alpha-3
> Reporter: Tomasz Pik
> Assignee: Brian Fox
> Fix For: 1.0
>
> Attachments: RequireReleaseDeps.patch
>
>
> 'noSnapshots' is passing when parent is defined to be SNAPSHOT, IMHO parent is also a dependency so it should be checked and rule should throw an error if parent is a SNAPSHOT.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MENFORCER-37) 'noSnapshots' rule do not check
version of parent
Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MENFORCER-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=139190#action_139190 ]
Brian Fox commented on MENFORCER-37:
------------------------------------
Default on sounds fine to me, it's definitely in the intent of the rule.
> 'noSnapshots' rule do not check version of parent
> -------------------------------------------------
>
> Key: MENFORCER-37
> URL: http://jira.codehaus.org/browse/MENFORCER-37
> Project: Maven 2.x Enforcer Plugin
> Issue Type: Bug
> Components: Standard Rules
> Affects Versions: 1.0-alpha-3
> Reporter: Tomasz Pik
> Assignee: Brian Fox
> Fix For: 1.0
>
> Attachments: RequireReleaseDeps.patch
>
>
> 'noSnapshots' is passing when parent is defined to be SNAPSHOT, IMHO parent is also a dependency so it should be checked and rule should throw an error if parent is a SNAPSHOT.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MENFORCER-37) 'noSnapshots' rule do not check
version of parent
Posted by "Nick Stolwijk (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MENFORCER-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=139022#action_139022 ]
Nick Stolwijk commented on MENFORCER-37:
----------------------------------------
The "noSnapshots" rules is deprecated and replaced by the "RequireReleaseDeps" rule. I've attached a patch to change this rule to also check for the parent. This is turned on by default, and it is possible to turn it off. Maybe the default should be turned off, but I'll leave that to Brian.
> 'noSnapshots' rule do not check version of parent
> -------------------------------------------------
>
> Key: MENFORCER-37
> URL: http://jira.codehaus.org/browse/MENFORCER-37
> Project: Maven 2.x Enforcer Plugin
> Issue Type: Bug
> Components: Standard Rules
> Affects Versions: 1.0-alpha-3
> Reporter: Tomasz Pik
> Assignee: Brian Fox
> Fix For: 1.0
>
> Attachments: RequireReleaseDeps.patch
>
>
> 'noSnapshots' is passing when parent is defined to be SNAPSHOT, IMHO parent is also a dependency so it should be checked and rule should throw an error if parent is a SNAPSHOT.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira