You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "dkropachev (via GitHub)" <gi...@apache.org> on 2024/09/14 10:50:58 UTC
[PR] Fix CustomCcmRule to drop `CURRENT` flag no matter what [cassandra-java-driver]
dkropachev opened a new pull request, #1961:
URL: https://github.com/apache/cassandra-java-driver/pull/1961
It is follow up for https://github.com/apache/cassandra-java-driver/pull/1720
If `super.after()` throws an Exception `CURRENT` flag is never dropped which leads next tests with `CustomCcmMRule` to fail with `IllegalStateException("Attempting to use a Ccm rule while another is in use. This is disallowed")`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Fix CustomCcmRule to drop `CURRENT` flag no matter what [cassandra-java-driver]
Posted by "tolbertam (via GitHub)" <gi...@apache.org>.
tolbertam commented on PR #1961:
URL: https://github.com/apache/cassandra-java-driver/pull/1961#issuecomment-2359722495
Thanks for the review and the testing @absurdfarce!
@dkropachev, if you could, can you amend your commit to include this in the last line and force push?:
> Patch by Dmitry Kropachev; reviewed by Andy Tolbert and Bret McGuire for JAVA-3117
(Reusing JAVA-3117 as this was a follow on). After that I'll merge it, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Fix CustomCcmRule to drop `CURRENT` flag no matter what [cassandra-java-driver]
Posted by "tolbertam (via GitHub)" <gi...@apache.org>.
tolbertam commented on PR #1961:
URL: https://github.com/apache/cassandra-java-driver/pull/1961#issuecomment-2442932564
Committed as https://github.com/apache/cassandra-java-driver/commit/dfe11a8b671d76be6c4e90981a736325b0e4719b with the extra patch info, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Fix CustomCcmRule to drop `CURRENT` flag no matter what [cassandra-java-driver]
Posted by "tolbertam (via GitHub)" <gi...@apache.org>.
tolbertam commented on PR #1961:
URL: https://github.com/apache/cassandra-java-driver/pull/1961#issuecomment-2442337824
i'll go ahead and commit this today :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Fix CustomCcmRule to drop `CURRENT` flag no matter what [cassandra-java-driver]
Posted by "dkropachev (via GitHub)" <gi...@apache.org>.
dkropachev commented on PR #1961:
URL: https://github.com/apache/cassandra-java-driver/pull/1961#issuecomment-2350950107
@lukasz-antoniak , @tolbertam, could you please take a look at it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Fix CustomCcmRule to drop `CURRENT` flag no matter what [cassandra-java-driver]
Posted by "tolbertam (via GitHub)" <gi...@apache.org>.
tolbertam closed pull request #1961: Fix CustomCcmRule to drop `CURRENT` flag no matter what
URL: https://github.com/apache/cassandra-java-driver/pull/1961
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Fix CustomCcmRule to drop `CURRENT` flag no matter what [cassandra-java-driver]
Posted by "absurdfarce (via GitHub)" <gi...@apache.org>.
absurdfarce commented on PR #1961:
URL: https://github.com/apache/cassandra-java-driver/pull/1961#issuecomment-2359424407
Agree that the current behaviour is incorrect; an exception in super.after() shouldn't lead to subsequent failures. I've kicked off a Jenkins run to make sure there isn't any unexpected regression here (I'll be very surprised if there is) so once that's complete with issue this gets a +1 from me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Fix CustomCcmRule to drop `CURRENT` flag no matter what [cassandra-java-driver]
Posted by "absurdfarce (via GitHub)" <gi...@apache.org>.
absurdfarce commented on PR #1961:
URL: https://github.com/apache/cassandra-java-driver/pull/1961#issuecomment-2359602730
Jenkins run looks good: one test failure but it's from a test that's known to fail intermittently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org